diff options
| author | ubudzisz <ubudzisz@gmail.com> | 2016-09-06 11:49:40 +0200 |
|---|---|---|
| committer | ubudzisz <ubudzisz@gmail.com> | 2016-09-06 14:42:43 +0200 |
| commit | 790d7cce968260b28e451483606c44ec340f6d80 (patch) | |
| tree | 25500ade0c5298dfdf3c697f606225d57434b169 | |
| parent | 691644dc5be544af0b0793353ab7f151136f1198 (diff) | |
| download | gitlab-ce-790d7cce968260b28e451483606c44ec340f6d80.tar.gz | |
improve code after review
| -rw-r--r-- | app/views/projects/builds/_sidebar.html.haml | 2 | ||||
| -rw-r--r-- | spec/features/projects/builds_spec.rb | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/app/views/projects/builds/_sidebar.html.haml b/app/views/projects/builds/_sidebar.html.haml index ba5354a1690..56306b05934 100644 --- a/app/views/projects/builds/_sidebar.html.haml +++ b/app/views/projects/builds/_sidebar.html.haml @@ -90,7 +90,7 @@ - if @build.trigger_request.variables %p - .btn.group.btn-group-justified.reveal-variables Reveal Variables + %button.btn.group.btn-group-justified.reveal-variables Reveal Variables - @build.trigger_request.variables.each do |key, value| diff --git a/spec/features/projects/builds_spec.rb b/spec/features/projects/builds_spec.rb index ea9e33ce722..d1685f95503 100644 --- a/spec/features/projects/builds_spec.rb +++ b/spec/features/projects/builds_spec.rb @@ -177,7 +177,7 @@ describe "Builds" do expect(page).not_to have_css('.js-build-variable') expect(page).not_to have_css('.js-build-value') - find('.reveal-variables').click + click_button 'Reveal Variables' expect(page).not_to have_css('.reveal-variables') expect(page).to have_selector('.js-build-variable', text: 'TRIGGER_KEY_1') |