diff options
author | Phil Hughes <me@iamphill.com> | 2018-11-21 13:05:39 +0000 |
---|---|---|
committer | Phil Hughes <me@iamphill.com> | 2018-11-21 13:05:39 +0000 |
commit | 74e18035d98f3238be5ef1933e43ce2b3f52bbf8 (patch) | |
tree | 23e036412d10ffc4911254f3e27f9f1784cd5a6b | |
parent | 6a12e9d10768d0ff06b357be7ac975cebffa3584 (diff) | |
parent | d55650f045335f52ad833b5ba00990549bb032f5 (diff) | |
download | gitlab-ce-74e18035d98f3238be5ef1933e43ce2b3f52bbf8.tar.gz |
Merge branch '54282-tooltip-stuck' into 'master'
Fixes stuck tooltip on stop env button
Closes #53571 and #54282
See merge request gitlab-org/gitlab-ce!23244
-rw-r--r-- | app/assets/javascripts/vue_merge_request_widget/components/deployment.vue | 8 | ||||
-rw-r--r-- | changelogs/unreleased/54282-tooltip-stuck.yml | 5 |
2 files changed, 9 insertions, 4 deletions
diff --git a/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue b/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue index c0cf1b2f656..950347d8863 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue @@ -1,10 +1,10 @@ <script> +import { GlTooltipDirective } from '@gitlab/ui'; import Icon from '~/vue_shared/components/icon.vue'; import TooltipOnTruncate from '~/vue_shared/components/tooltip_on_truncate.vue'; import FilteredSearchDropdown from '~/vue_shared/components/filtered_search_dropdown.vue'; import { __ } from '~/locale'; import timeagoMixin from '../../vue_shared/mixins/timeago'; -import tooltip from '../../vue_shared/directives/tooltip'; import LoadingButton from '../../vue_shared/components/loading_button.vue'; import { visitUrl } from '../../lib/utils/url_utility'; import createFlash from '../../flash'; @@ -25,7 +25,7 @@ export default { ReviewAppLink, }, directives: { - tooltip, + GlTooltip: GlTooltipDirective, }, mixins: [timeagoMixin], props: { @@ -136,7 +136,7 @@ export default { </template> <span v-if="hasDeploymentTime" - v-tooltip + v-gl-tooltip :title="deployment.deployed_at_formatted" class="js-deploy-time" > @@ -189,7 +189,7 @@ export default { </template> <span v-if="deployment.stop_url" - v-tooltip + v-gl-tooltip :title="deployInProgressTooltip" class="d-inline-block" tabindex="0" diff --git a/changelogs/unreleased/54282-tooltip-stuck.yml b/changelogs/unreleased/54282-tooltip-stuck.yml new file mode 100644 index 00000000000..655870499a0 --- /dev/null +++ b/changelogs/unreleased/54282-tooltip-stuck.yml @@ -0,0 +1,5 @@ +--- +title: Fixes stuck tooltip on stop env button +merge_request: 23244 +author: +type: fixed |