summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorcharlieablett <cablett@gitlab.com>2019-04-26 09:40:00 +1200
committercharlieablett <cablett@gitlab.com>2019-04-26 09:40:00 +1200
commit4bd331a568cff64f4097fdf0cc4e45727750f740 (patch)
tree581d8967ccc2afbfe7b598c6b3023e49393de57e
parent8eae788fd4248db1fcab2062195e542baf04c936 (diff)
downloadgitlab-ce-4bd331a568cff64f4097fdf0cc4e45727750f740.tar.gz
Tighten up prohibited_key method
-rw-r--r--lib/gitlab/import_export/attribute_cleaner.rb5
1 files changed, 2 insertions, 3 deletions
diff --git a/lib/gitlab/import_export/attribute_cleaner.rb b/lib/gitlab/import_export/attribute_cleaner.rb
index 2d64ea77060..f476905b6db 100644
--- a/lib/gitlab/import_export/attribute_cleaner.rb
+++ b/lib/gitlab/import_export/attribute_cleaner.rb
@@ -29,10 +29,9 @@ module Gitlab
return true if 'cached_markdown_version'.equal?(key)
prohibited_suffixes = %w(_id _html)
- prohibited_suffixes.each do |suffix|
- return true if key.end_with?(suffix)
+ prohibited_suffixes.any? do |suffix|
+ true if key.end_with?(suffix)
end
- false
end
def allowed_reference?(key)