summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Slaughter <pslaughter@gitlab.com>2019-06-05 06:04:33 -0500
committerPaul Slaughter <pslaughter@gitlab.com>2019-06-05 08:53:55 -0500
commitc9c7fa7bbbbecf8d6af0936d7004c2d9469aed78 (patch)
treeb91472aaf08a51662dd716c9304cecbb1d22cc62
parent202e525119188721004c4a1eb6be18c9cf7a6f5e (diff)
downloadgitlab-ce-c9c7fa7bbbbecf8d6af0936d7004c2d9469aed78.tar.gz
Fix label click scrolling to top
-rw-r--r--app/assets/javascripts/gl_dropdown.js5
-rw-r--r--changelogs/unreleased/61246-fix-label-click-scroll-to-top.yml5
2 files changed, 10 insertions, 0 deletions
diff --git a/app/assets/javascripts/gl_dropdown.js b/app/assets/javascripts/gl_dropdown.js
index 18fa6265108..05f34391323 100644
--- a/app/assets/javascripts/gl_dropdown.js
+++ b/app/assets/javascripts/gl_dropdown.js
@@ -565,6 +565,11 @@ GitLabDropdown = (function() {
!$target.data('isLink')
) {
e.stopPropagation();
+
+ // This prevents automatic scrolling to the top
+ if ($target.is('a')) {
+ return false;
+ }
}
return true;
diff --git a/changelogs/unreleased/61246-fix-label-click-scroll-to-top.yml b/changelogs/unreleased/61246-fix-label-click-scroll-to-top.yml
new file mode 100644
index 00000000000..7fa15e1c0fd
--- /dev/null
+++ b/changelogs/unreleased/61246-fix-label-click-scroll-to-top.yml
@@ -0,0 +1,5 @@
+---
+title: Fix label click scrolling to top
+merge_request: 29202
+author:
+type: fixed