diff options
| author | Richard Clamp <richardc@unixbeard.net> | 2017-11-08 12:13:47 +0000 |
|---|---|---|
| committer | Richard Clamp <richardc@unixbeard.net> | 2017-11-08 12:13:47 +0000 |
| commit | e1f037980fda1620c2ba6ed407c35349989275fa (patch) | |
| tree | c319c00010999fd343137fdeecc38f878992d5f7 | |
| parent | 92249f1ac883c2a861235ec49526cbafca73b362 (diff) | |
| download | gitlab-ce-e1f037980fda1620c2ba6ed407c35349989275fa.tar.gz | |
Fix test selection in Test::Integration::Mattermost
In ce3b81b953f we changed Test::Integration::Mattermost#perform to
consume a required positional parameter and pass on the rest of the
arguments to the superclass. There was an error in implementation here
and instead of splatting the files array to produce no additional
arguments, we passed in the default case an empty array.
This had the effect of calling rspec with no test files,
rather than expected default of 'qa/specs/features`
Here we correct that bug, and re-add the :core suite, as that was a poor
deuction in the investagtion for 74d6b8a211.
| -rw-r--r-- | qa/qa/scenario/test/integration/mattermost.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/qa/qa/scenario/test/integration/mattermost.rb b/qa/qa/scenario/test/integration/mattermost.rb index 59d7dcd3d23..0220da929ce 100644 --- a/qa/qa/scenario/test/integration/mattermost.rb +++ b/qa/qa/scenario/test/integration/mattermost.rb @@ -7,11 +7,11 @@ module QA # including staging and on-premises installation. # class Mattermost < Scenario::Entrypoint - tags :mattermost + tags :core, :mattermost def perform(address, mattermost, *files) Runtime::Scenario.mattermost = mattermost - super(address, files) + super(address, *files) end end end |