Add env_scope tests

2 files changed, 33 insertions, 0 deletions

diff --git a/db/post_migrate/20171124104327_migrate_kubernetes_service_to_new_clusters_architectures.rb b/db/post_migrate/20171124104327_migrate_kubernetes_service_to_new_clusters_architectures.rb
index e05d206eb9c..5dee8cb8c5f 100644
--- a/db/post_migrate/20171124104327_migrate_kubernetes_service_to_new_clusters_architectures.rb
+++ b/db/post_migrate/20171124104327_migrate_kubernetes_service_to_new_clusters_architectures.rb
@@ -88,6 +88,7 @@ class MigrateKubernetesServiceToNewClustersArchitectures < ActiveRecord::Migrati
           provider_type: Cluster.provider_types[:user],
           platform_type: Cluster.platform_types[:kubernetes],
           projects: [kubernetes_service.project],
+          environment_scope: '*', # KubernetesService is considered as a default cluster
           platform_kubernetes_attributes: {
             api_url: kubernetes_service.api_url,
             ca_cert: kubernetes_service.ca_pem,
diff --git a/spec/migrations/migrate_kubernetes_service_to_new_clusters_architectures_spec.rb b/spec/migrations/migrate_kubernetes_service_to_new_clusters_architectures_spec.rb
index d3fa1fe9054..bf41b2df359 100644
--- a/spec/migrations/migrate_kubernetes_service_to_new_clusters_architectures_spec.rb
+++ b/spec/migrations/migrate_kubernetes_service_to_new_clusters_architectures_spec.rb
@@ -113,6 +113,38 @@ describe MigrateKubernetesServiceToNewClustersArchitectures, :migration do
     end
   end
 
+  context 'when production cluster has already been existsed' do
+    let(:project) { create(:project) }
+    let!(:cluster) { create(:cluster, :provided_by_gcp, environment_scope: 'production/*', projects: [project]) }
+    let!(:kubernetes_service) { create(:kubernetes_service, api_url: 'https://debug.kube.com', active: true, project: project) }
+
+    it 'migrates the KubernetesService to Platform::Kubernetes' do
+      expect{ migrate! }.to change { Clusters::Cluster.count }.by(1)
+
+      kubernetes_service.reload
+      project.clusters.last.tap do |cluster|
+        expect(cluster.platform_kubernetes.api_url).to eq(kubernetes_service.api_url)
+        expect(cluster.platform_kubernetes.ca_pem).to eq(kubernetes_service.ca_pem)
+        expect(cluster.platform_kubernetes.token).to eq(kubernetes_service.token)
+        expect(kubernetes_service).not_to be_active
+        expect(kubernetes_service.properties['migrated']).to be_truthy
+      end
+    end
+  end
+
+  context 'when default cluster has already been existsed' do
+    let(:project) { create(:project) }
+    let!(:cluster) { create(:cluster, :provided_by_gcp, environment_scope: '*', projects: [project]) }
+    let!(:kubernetes_service) { create(:kubernetes_service, api_url: 'https://debug.kube.com', active: true, project: project) }
+
+    it 'does not migrate the KubernetesService' do # Because environment_scope is duplicated
+      expect{ migrate! }.not_to change { Clusters::Cluster.count }
+
+      expect(kubernetes_service).to be_active
+      expect(kubernetes_service.properties['migrated']).to be_falsy
+    end
+  end
+
   context 'when KubernetesService does not exist' do
     let!(:project) { create(:project) }