summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGrzegorz Bizon <grzegorz@gitlab.com>2018-02-15 12:28:29 +0000
committerGrzegorz Bizon <grzegorz@gitlab.com>2018-02-15 12:28:29 +0000
commit6d70a62a61c7ec7bad2a32aa577b74dcda303ed4 (patch)
tree652e4411709108757efc5deeb9c9e8851fc3c77d
parent6444eca2be63cdc11090b2634aaa3648b1079ca8 (diff)
parent0a9131f9971a655aecca2d5abd33bded5b4b2664 (diff)
downloadgitlab-ce-6d70a62a61c7ec7bad2a32aa577b74dcda303ed4.tar.gz
Merge branch '31049-pages-domains-should-be-added-to-publicsuffix-org-docs' into 'master'
Resolve "HackerOne reported issue: Cookie bomb vulnerability in Pages" Closes #31049 See merge request gitlab-org/gitlab-ce!17123
-rw-r--r--doc/administration/pages/index.md15
1 files changed, 15 insertions, 0 deletions
diff --git a/doc/administration/pages/index.md b/doc/administration/pages/index.md
index 7d47aaac299..edb3e4c961e 100644
--- a/doc/administration/pages/index.md
+++ b/doc/administration/pages/index.md
@@ -61,6 +61,21 @@ Before proceeding with the Pages configuration, you will need to:
NOTE: **Note:**
If your GitLab instance and the Pages daemon are deployed in a private network or behind a firewall, your GitLab Pages websites will only be accessible to devices/users that have access to the private network.
+### Add the domain to the Public Suffix List
+
+The [Public Suffix List](https://publicsuffix.org) is used by browsers to
+decide how to treat subdomains. If your GitLab instance allows members of the
+public to create GitLab Pages sites, it also allows those users to create
+subdomains on the pages domain (`example.io`). Adding the domain to the Public
+Suffix List prevents browsers from accepting
+[supercookies](https://en.wikipedia.org/wiki/HTTP_cookie#Supercookie),
+among other things.
+
+Follow [these instructions](https://publicsuffix.org/submit/) to submit your
+GitLab Pages subdomain. For instance, if your domain is `example.io`, you should
+request that `*.example.io` is added to the Public Suffix List. GitLab.com
+added `*.gitlab.io` [in 2016](https://gitlab.com/gitlab-com/infrastructure/issues/230).
+
### DNS configuration
GitLab Pages expect to run on their own virtual host. In your DNS server/provider