diff options
| author | Evan Read <eread@gitlab.com> | 2019-09-04 03:09:06 +0000 |
|---|---|---|
| committer | Evan Read <eread@gitlab.com> | 2019-09-04 03:09:06 +0000 |
| commit | df6f1dd93f0f427a2c66c07ea31bdb17a7efaca6 (patch) | |
| tree | d18e88e843bbb4173b342e087526c2e015315526 | |
| parent | 4c9858431655c5e263dc73c4f5d36cbce3f55b6f (diff) | |
| parent | 6d0238a38c05e81d1c07284714d3cc01a257d1aa (diff) | |
| download | gitlab-ce-df6f1dd93f0f427a2c66c07ea31bdb17a7efaca6.tar.gz | |
Merge branch 'docs-updates-database-review-merge-request-author-responsibility' into 'master'
Update merge request author's responsibility on Database Review
See merge request gitlab-org/gitlab-ce!32558
| -rw-r--r-- | doc/development/database_review.md | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/doc/development/database_review.md b/doc/development/database_review.md index 367a481ee11..157c64b514c 100644 --- a/doc/development/database_review.md +++ b/doc/development/database_review.md @@ -38,6 +38,7 @@ A Merge Request author's role is to: - If database review is needed, add the ~database label. - Use the [database changes](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/.gitlab/merge_request_templates/Database%20changes.md) merge request template, or include the appropriate items in the MR description. +- [Prepare the merge request for a database review](#how-to-prepare-the-merge-request-for-a-database-review). A database **reviewer**'s role is to: @@ -68,7 +69,7 @@ make sure you have applied the ~database label and rerun the `danger-review` CI job, or pick someone from the [`@gl-database` team](https://gitlab.com/groups/gl-database/-/group_members). -### How to prepare for speedy database reviews +### How to prepare the merge request for a database review In order to make reviewing easier and therefore faster, please consider preparing a comment and details for a database reviewer: |