diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-09-04 17:07:53 +0000 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-09-04 17:07:53 +0000 |
| commit | bddaee749a51a83161ab3ff96bf7d17f1537fdcf (patch) | |
| tree | 094ee1ad43a69f6f72c0600d565bf72f38b832e8 | |
| parent | 0b10a83440b9a4559030043269903ab409c9486d (diff) | |
| parent | a3de0cd60369f6ee70e98a47b8db5a309a655354 (diff) | |
| download | gitlab-ce-bddaee749a51a83161ab3ff96bf7d17f1537fdcf.tar.gz | |
Merge branch 'remove-unnecessary-freeze-in-app-finders' into 'master'
Avoid calling freeze on already frozen strings in app/finders
See merge request gitlab-org/gitlab-ce!32634
| -rw-r--r-- | app/finders/issuable_finder.rb | 6 | ||||
| -rw-r--r-- | app/finders/todos_finder.rb | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/app/finders/issuable_finder.rb b/app/finders/issuable_finder.rb index 1773ac2d508..b735f9ff3b8 100644 --- a/app/finders/issuable_finder.rb +++ b/app/finders/issuable_finder.rb @@ -40,11 +40,11 @@ class IssuableFinder requires_cross_project_access unless: -> { project? } # This is used as a common filter for None / Any - FILTER_NONE = 'none'.freeze - FILTER_ANY = 'any'.freeze + FILTER_NONE = 'none' + FILTER_ANY = 'any' # This is used in unassigning users - NONE = '0'.freeze + NONE = '0' attr_accessor :current_user, :params diff --git a/app/finders/todos_finder.rb b/app/finders/todos_finder.rb index d001e18fea9..ed6d20b9585 100644 --- a/app/finders/todos_finder.rb +++ b/app/finders/todos_finder.rb @@ -21,7 +21,7 @@ class TodosFinder requires_cross_project_access unless: -> { project? } - NONE = '0'.freeze + NONE = '0' TODO_TYPES = Set.new(%w(Issue MergeRequest Epic)).freeze |