summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2018-01-09 20:24:52 +0000
committerFilipa Lacerda <filipa@gitlab.com>2018-01-09 20:24:52 +0000
commit340d0002f0b2e1487e0650906a82030457adf32e (patch)
tree132fd38d549c3e199ca7e34218d46a57d68d6469
parentee90edae274dbbd99e78100ae8df3195f21e0ef0 (diff)
downloadgitlab-ce-340d0002f0b2e1487e0650906a82030457adf32e.tar.gz
Disable rule in modal.vue breaking tests
-rw-r--r--app/assets/javascripts/vue_shared/components/modal.vue8
1 files changed, 3 insertions, 5 deletions
diff --git a/app/assets/javascripts/vue_shared/components/modal.vue b/app/assets/javascripts/vue_shared/components/modal.vue
index da0ba18e40f..4babfcea5c1 100644
--- a/app/assets/javascripts/vue_shared/components/modal.vue
+++ b/app/assets/javascripts/vue_shared/components/modal.vue
@@ -1,4 +1,5 @@
<script>
+ /* eslint-disable vue/require-default-prop */
export default {
name: 'Modal',
@@ -6,17 +7,14 @@
id: {
type: String,
required: false,
- default: '',
},
title: {
type: String,
required: false,
- default: '',
},
text: {
type: String,
required: false,
- default: '',
},
hideFooter: {
type: Boolean,
@@ -84,7 +82,7 @@
<div
:id="id"
class="modal"
- :class="id === '' ? '' : 'show'"
+ :class="!id ? '' : 'show'"
role="dialog"
tabindex="-1"
>
@@ -147,7 +145,7 @@
</div>
</div>
<div
- v-if="id === ''"
+ v-if="!id"
class="modal-backdrop fade in"
>
</div>