summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2018-01-09 10:48:02 +0000
committerFilipa Lacerda <filipa@gitlab.com>2018-01-09 10:52:49 +0000
commite28e1f4226a0643638679907aadd42d1843fc48f (patch)
tree46a8099e02a68bdecf49648d6593044cac6a13fd
parent7e3405d76cbd683ea557835c4cd96af9bda9cf4c (diff)
downloadgitlab-ce-e28e1f4226a0643638679907aadd42d1843fc48f.tar.gz
[ci skip] Fix pagination specs
-rw-r--r--app/assets/javascripts/vue_shared/components/table_pagination.vue7
-rw-r--r--spec/javascripts/vue_shared/components/table_pagination_spec.js1
2 files changed, 3 insertions, 5 deletions
diff --git a/app/assets/javascripts/vue_shared/components/table_pagination.vue b/app/assets/javascripts/vue_shared/components/table_pagination.vue
index 5aa2aee8882..c44c606a8b2 100644
--- a/app/assets/javascripts/vue_shared/components/table_pagination.vue
+++ b/app/assets/javascripts/vue_shared/components/table_pagination.vue
@@ -93,10 +93,9 @@
},
},
methods: {
- changePage(e) {
- if (e.target.parentElement.classList.contains('disabled')) return;
+ changePage(text, isDisabled) {
+ if (isDisabled) return;
- const text = e.target.innerText;
const { totalPages, nextPage, previousPage } = this.pageInfo;
switch (text) {
@@ -142,7 +141,7 @@
disabled: item.disabled
}"
>
- <a @click.prevent="changePage($event)">
+ <a @click.prevent="changePage(item.title, item.disabled)">
{{ item.title }}
</a>
</li>
diff --git a/spec/javascripts/vue_shared/components/table_pagination_spec.js b/spec/javascripts/vue_shared/components/table_pagination_spec.js
index 1465ef5855f..153b5c51cbf 100644
--- a/spec/javascripts/vue_shared/components/table_pagination_spec.js
+++ b/spec/javascripts/vue_shared/components/table_pagination_spec.js
@@ -72,7 +72,6 @@ describe('Pagination component', () => {
});
component.$el.querySelector('.js-previous-button a').click();
-
expect(spy).toHaveBeenCalledWith(1);
});
});