Merge branch '50323-fix-clusters-application-prometheus-test' into 'master'

Resolve "Fix bad test from 20765 MR"

Closes #50323

See merge request gitlab-org/gitlab-ce!21219

1 files changed, 7 insertions, 10 deletions

diff --git a/spec/models/clusters/applications/prometheus_spec.rb b/spec/models/clusters/applications/prometheus_spec.rb
index 7454be3ab2f..26b75c75e1d 100644
--- a/spec/models/clusters/applications/prometheus_spec.rb
+++ b/spec/models/clusters/applications/prometheus_spec.rb
@@ -154,20 +154,17 @@ describe Clusters::Applications::Prometheus do
   end
 
   describe '#install_command' do
-    let(:kubeclient) { double('kubernetes client') }
     let(:prometheus) { create(:clusters_applications_prometheus) }
 
-    it 'returns an instance of Gitlab::Kubernetes::Helm::InstallCommand' do
-      expect(prometheus.install_command).to be_an_instance_of(Gitlab::Kubernetes::Helm::InstallCommand)
-    end
+    subject { prometheus.install_command }
 
-    it 'should be initialized with 3 arguments' do
-      command = prometheus.install_command
+    it { is_expected.to be_an_instance_of(Gitlab::Kubernetes::Helm::InstallCommand) }
 
-      expect(command.name).to eq('prometheus')
-      expect(command.chart).to eq('stable/prometheus')
-      expect(command.version).to eq('6.7.3')
-      expect(command.files).to eq(prometheus.files)
+    it 'should be initialized with 3 arguments' do
+      expect(subject.name).to eq('prometheus')
+      expect(subject.chart).to eq('stable/prometheus')
+      expect(subject.version).to eq('6.7.3')
+      expect(subject.files).to eq(prometheus.files)
     end
 
     context 'application failed to install previously' do