summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2015-03-18 20:12:19 -0700
committerDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2015-03-18 20:12:19 -0700
commit1cf138170c17913b180e7b3d2840ca4439c618a1 (patch)
tree2e5700d5280c8763ca098299541ba6a03c80887f
parente07d32eb418584bef4289260fcb4792d6b6ca39e (diff)
downloadgitlab-ce-1cf138170c17913b180e7b3d2840ca4439c618a1.tar.gz
Add tooltip for comment toggle in diff. Add changelog item and fix tests
-rw-r--r--CHANGELOG1
-rw-r--r--app/views/projects/diffs/_file.html.haml2
-rw-r--r--features/steps/project/merge_requests.rb4
3 files changed, 4 insertions, 3 deletions
diff --git a/CHANGELOG b/CHANGELOG
index 22f38024f93..328c672338d 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -6,6 +6,7 @@ v 7.10.0 (unreleased)
- Add a service to support external wikis (Hannes Rosenögger)
- List new commits for newly pushed branch in activity view.
- Add changelog, license and contribution guide links to project sidebar.
+ - Improve diff UI
v 7.9.0 (unreleased)
- Add HipChat integration documentation (Stan Hu)
diff --git a/app/views/projects/diffs/_file.html.haml b/app/views/projects/diffs/_file.html.haml
index 2beb768b926..860ab096341 100644
--- a/app/views/projects/diffs/_file.html.haml
+++ b/app/views/projects/diffs/_file.html.haml
@@ -22,7 +22,7 @@
.diff-btn-group
- if blob.text?
- = link_to '#', class: 'js-toggle-diff-comments btn btn-sm active' do
+ = link_to '#', class: 'js-toggle-diff-comments btn btn-sm active has_tooltip', title: "Toggle comments for this file" do
%i.fa.fa-comments
&nbsp;
diff --git a/features/steps/project/merge_requests.rb b/features/steps/project/merge_requests.rb
index 6e2f60972b6..6f6ce439f3e 100644
--- a/features/steps/project/merge_requests.rb
+++ b/features/steps/project/merge_requests.rb
@@ -209,13 +209,13 @@ class Spinach::Features::ProjectMergeRequests < Spinach::FeatureSteps
step 'I click link "Hide inline discussion" of the second file' do
within '.files [id^=diff]:nth-child(2)' do
- click_link 'Show/Hide comments'
+ find('.js-toggle-diff-comments').click
end
end
step 'I click link "Show inline discussion" of the second file' do
within '.files [id^=diff]:nth-child(2)' do
- click_link 'Show/Hide comments'
+ find('.js-toggle-diff-comments').click
end
end