diff options
| author | Nick Thomas <nick@gitlab.com> | 2019-03-09 12:30:19 +0000 |
|---|---|---|
| committer | Nick Thomas <nick@gitlab.com> | 2019-03-09 13:34:06 +0000 |
| commit | 452f5081434973ea512fe75c317354b3893f00e4 (patch) | |
| tree | 433bbbdb477f30b943c6ad276e70159172f12d1a | |
| parent | 106888fb51bd1e63c0ee2f1ca84653b7f9416f6f (diff) | |
| download | gitlab-ce-452f5081434973ea512fe75c317354b3893f00e4.tar.gz | |
Fix the last-ditch memory killer pgroup SIGKILL
| -rw-r--r-- | changelogs/unreleased/more-pgroup-fix.yml | 5 | ||||
| -rw-r--r-- | lib/gitlab/sidekiq_middleware/memory_killer.rb | 2 | ||||
| -rw-r--r-- | spec/lib/gitlab/sidekiq_middleware/memory_killer_spec.rb | 2 |
3 files changed, 7 insertions, 2 deletions
diff --git a/changelogs/unreleased/more-pgroup-fix.yml b/changelogs/unreleased/more-pgroup-fix.yml new file mode 100644 index 00000000000..6e85205ccba --- /dev/null +++ b/changelogs/unreleased/more-pgroup-fix.yml @@ -0,0 +1,5 @@ +--- +title: Fix the last-ditch memory killer pgroup SIGKILL +merge_request: 25940 +author: +type: fixed diff --git a/lib/gitlab/sidekiq_middleware/memory_killer.rb b/lib/gitlab/sidekiq_middleware/memory_killer.rb index ed2c7ee9a2d..671d795ec33 100644 --- a/lib/gitlab/sidekiq_middleware/memory_killer.rb +++ b/lib/gitlab/sidekiq_middleware/memory_killer.rb @@ -63,7 +63,7 @@ module Gitlab sleep(time) Sidekiq.logger.warn "sending Sidekiq worker PGRP-#{pid} #{signal} (#{explanation})" - Process.kill(signal, "-#{pid}") + Process.kill(signal, 0) end def wait_and_signal(time, signal, explanation) diff --git a/spec/lib/gitlab/sidekiq_middleware/memory_killer_spec.rb b/spec/lib/gitlab/sidekiq_middleware/memory_killer_spec.rb index ff8c0825ee4..1a5a38b5d99 100644 --- a/spec/lib/gitlab/sidekiq_middleware/memory_killer_spec.rb +++ b/spec/lib/gitlab/sidekiq_middleware/memory_killer_spec.rb @@ -54,7 +54,7 @@ describe Gitlab::SidekiqMiddleware::MemoryKiller do expect(Process).to receive(:kill).with('SIGTSTP', pid).ordered expect(Process).to receive(:kill).with('SIGTERM', pid).ordered - expect(Process).to receive(:kill).with('SIGKILL', "-#{pid}").ordered + expect(Process).to receive(:kill).with('SIGKILL', 0).ordered run end |