summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDouwe Maan <douwe@gitlab.com>2018-12-18 14:24:22 +0000
committerDouwe Maan <douwe@gitlab.com>2018-12-18 14:24:22 +0000
commit4a6c5546cd6a3325e9a71cf4f7e097aedc3ce382 (patch)
tree00f8bcb4d92b3cb8093c3bd077126f3c5dfdf6e3
parentaa7c927e1e4f114fea381d3856d195319f0ca0a1 (diff)
parent4b0988aa020a9f2fc887b70f82711c9e5b708f49 (diff)
downloadgitlab-ce-4a6c5546cd6a3325e9a71cf4f7e097aedc3ce382.tar.gz
Merge branch 'fj-remove-forced-disposition-attachment-ssh-keys' into 'master'
Remove content disposition attachment displaying all ssh keys See merge request gitlab-org/gitlab-ce!23882
-rw-r--r--app/controllers/profiles/keys_controller.rb1
-rw-r--r--spec/controllers/profiles/keys_controller_spec.rb6
2 files changed, 0 insertions, 7 deletions
diff --git a/app/controllers/profiles/keys_controller.rb b/app/controllers/profiles/keys_controller.rb
index dcee8eb7e6e..055d900eece 100644
--- a/app/controllers/profiles/keys_controller.rb
+++ b/app/controllers/profiles/keys_controller.rb
@@ -40,7 +40,6 @@ class Profiles::KeysController < Profiles::ApplicationController
begin
user = UserFinder.new(params[:username]).find_by_username
if user.present?
- headers['Content-Disposition'] = 'attachment'
render plain: user.all_ssh_keys.join("\n")
else
return render_404
diff --git a/spec/controllers/profiles/keys_controller_spec.rb b/spec/controllers/profiles/keys_controller_spec.rb
index 685db8488f0..d55d15d0db8 100644
--- a/spec/controllers/profiles/keys_controller_spec.rb
+++ b/spec/controllers/profiles/keys_controller_spec.rb
@@ -65,12 +65,6 @@ describe Profiles::KeysController do
expect(response.content_type).to eq("text/plain")
end
-
- it "responds with attachment content disposition" do
- get :get_keys, username: user.username
-
- expect(response.headers['Content-Disposition']).to eq('attachment')
- end
end
end
end