diff options
| author | Dan Davison <ddavison@gitlab.com> | 2019-03-27 04:12:50 +0000 |
|---|---|---|
| committer | Dan Davison <ddavison@gitlab.com> | 2019-03-27 04:12:50 +0000 |
| commit | 5f0908bead7309354ae8d513ef85fb042ecd6b0a (patch) | |
| tree | 699be410da9cff30912781e96fa510fe6910ce23 | |
| parent | 535bd5743f932c3ab30e047929b32c3ade2f47e5 (diff) | |
| parent | a08b868e954efe9a1084f5afa0c0cf67c287d50a (diff) | |
| download | gitlab-ce-5f0908bead7309354ae8d513ef85fb042ecd6b0a.tar.gz | |
Merge branch 'qa-dd-improve-job-querying-successful' into 'master'
Make the job#successful? method wait by refreshing
See merge request gitlab-org/gitlab-ce!26344
| -rw-r--r-- | qa/qa/page/project/job/show.rb | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/qa/qa/page/project/job/show.rb b/qa/qa/page/project/job/show.rb index 9c218f4ed8b..5853f487f0b 100644 --- a/qa/qa/page/project/job/show.rb +++ b/qa/qa/page/project/job/show.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module QA::Page module Project::Job class Show < QA::Page::Base @@ -31,7 +33,9 @@ module QA::Page private def loaded?(wait: 60) - has_element?(:build_trace, wait: wait) + wait(reload: true, max: wait, interval: 1) do + has_element?(:build_trace, wait: 1) + end end def completed?(timeout: 60) |