summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhil Hughes <me@iamphill.com>2018-11-28 10:07:47 +0000
committerPhil Hughes <me@iamphill.com>2018-11-28 10:07:47 +0000
commit91e1824fe2c29023051c5338d5883a0e8ef915a6 (patch)
tree01e128ace22eb9fba1ec11059c44398ec04923e9
parent822fa649eba7d72fa01834c7b6477900051e221a (diff)
parente76a676599bf5fd693d99284c8708448fea4e296 (diff)
downloadgitlab-ce-91e1824fe2c29023051c5338d5883a0e8ef915a6.tar.gz
Merge branch 'sh-disable-autocomplete-mirror-settings' into 'master'
Disable password autocomplete in mirror form fill Closes #50812 See merge request gitlab-org/gitlab-ce!23402
-rw-r--r--app/views/projects/mirrors/_authentication_method.html.haml2
-rw-r--r--changelogs/unreleased/sh-disable-autocomplete-mirror-settings.yml5
2 files changed, 6 insertions, 1 deletions
diff --git a/app/views/projects/mirrors/_authentication_method.html.haml b/app/views/projects/mirrors/_authentication_method.html.haml
index 8dc042d87d1..3effdf934fb 100644
--- a/app/views/projects/mirrors/_authentication_method.html.haml
+++ b/app/views/projects/mirrors/_authentication_method.html.haml
@@ -15,7 +15,7 @@
.changing-auth-method= icon('spinner spin lg')
.well-password-auth.collapse.js-well-password-auth
= f.label :password, _("Password"), class: "label-bold"
- = f.password_field :password, value: mirror.password, class: 'form-control'
+ = f.password_field :password, value: mirror.password, class: 'form-control', autocomplete: 'new-password'
- unless is_push
.well-ssh-auth.collapse.js-well-ssh-auth
%p.js-ssh-public-key-present{ class: ('collapse' unless ssh_public_key_present) }
diff --git a/changelogs/unreleased/sh-disable-autocomplete-mirror-settings.yml b/changelogs/unreleased/sh-disable-autocomplete-mirror-settings.yml
new file mode 100644
index 00000000000..e42906e88f2
--- /dev/null
+++ b/changelogs/unreleased/sh-disable-autocomplete-mirror-settings.yml
@@ -0,0 +1,5 @@
+---
+title: Disable password autocomplete in mirror form fill
+merge_request: 23402
+author:
+type: fixed