summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWalmyr Lima <walmyr@gitlab.com>2019-03-22 17:19:37 +0100
committerWalmyr Lima <walmyr@gitlab.com>2019-03-22 17:34:40 +0100
commit93ed9de17928635b3e4b9a0d81006507bf54f24c (patch)
treeafda526419c73fd2cab3c4ac440056bd72576956
parent5e9b683da7cba7e5a5c0cd12b7f80f0360e78dd0 (diff)
downloadgitlab-ce-93ed9de17928635b3e4b9a0d81006507bf54f24c.tar.gz
Move details of e2e tests to the bottom
The code should be written like a newspaper, wherein the top we have more high level information, and as we go down we have more details. So I'm moving the implementation details to the bottom to make the test easier to read.
-rw-r--r--qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb18
1 files changed, 9 insertions, 9 deletions
diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb
index 7145b950b6c..358ab04eadc 100644
--- a/qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb
+++ b/qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb
@@ -5,15 +5,6 @@ module QA
describe 'Issue creation' do
let(:issue_title) { 'issue title' }
- def create_issue
- Runtime::Browser.visit(:gitlab, Page::Main::Login)
- Page::Main::Login.act { sign_in_using_credentials }
-
- Resource::Issue.fabricate! do |issue|
- issue.title = issue_title
- end
- end
-
it 'user creates an issue' do
create_issue
@@ -46,6 +37,15 @@ module QA
end
end
end
+
+ def create_issue
+ Runtime::Browser.visit(:gitlab, Page::Main::Login)
+ Page::Main::Login.act { sign_in_using_credentials }
+
+ Resource::Issue.fabricate! do |issue|
+ issue.title = issue_title
+ end
+ end
end
end
end