summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGrzegorz Bizon <grzesiek.bizon@gmail.com>2016-10-12 12:23:52 +0200
committerGrzegorz Bizon <grzesiek.bizon@gmail.com>2016-10-12 12:23:52 +0200
commit9eedd6f9c7baa5693a24c33c29909bfc7dac1b21 (patch)
treea4b75d37f6da63bcffaaafc15b1475f300cc46e7
parentdf404f551a29258fa5b97c0e7abe144fd7a0fb31 (diff)
downloadgitlab-ce-9eedd6f9c7baa5693a24c33c29909bfc7dac1b21.tar.gz
Improve desc for pipeline integration spec in MWBS
-rw-r--r--spec/services/merge_requests/merge_when_build_succeeds_service_spec.rb36
1 files changed, 19 insertions, 17 deletions
diff --git a/spec/services/merge_requests/merge_when_build_succeeds_service_spec.rb b/spec/services/merge_requests/merge_when_build_succeeds_service_spec.rb
index 01cdc172136..b80cfd8f450 100644
--- a/spec/services/merge_requests/merge_when_build_succeeds_service_spec.rb
+++ b/spec/services/merge_requests/merge_when_build_succeeds_service_spec.rb
@@ -98,7 +98,26 @@ describe MergeRequests::MergeWhenBuildSucceedsService do
service.trigger(unrelated_pipeline)
end
end
+ end
+
+ describe "#cancel" do
+ before do
+ service.cancel(mr_merge_if_green_enabled)
+ end
+
+ it "resets all the merge_when_build_succeeds params" do
+ expect(mr_merge_if_green_enabled.merge_when_build_succeeds).to be_falsey
+ expect(mr_merge_if_green_enabled.merge_params).to eq({})
+ expect(mr_merge_if_green_enabled.merge_user).to be nil
+ end
+
+ it 'Posts a system note' do
+ note = mr_merge_if_green_enabled.notes.last
+ expect(note.note).to include 'Canceled the automatic merge'
+ end
+ end
+ describe 'pipeline integration' do
context 'when there are multiple stages in the pipeline' do
let(:ref) { mr_merge_if_green_enabled.source_branch }
let(:sha) { project.commit(ref).id }
@@ -139,21 +158,4 @@ describe MergeRequests::MergeWhenBuildSucceedsService do
end
end
end
-
- describe "#cancel" do
- before do
- service.cancel(mr_merge_if_green_enabled)
- end
-
- it "resets all the merge_when_build_succeeds params" do
- expect(mr_merge_if_green_enabled.merge_when_build_succeeds).to be_falsey
- expect(mr_merge_if_green_enabled.merge_params).to eq({})
- expect(mr_merge_if_green_enabled.merge_user).to be nil
- end
-
- it 'Posts a system note' do
- note = mr_merge_if_green_enabled.notes.last
- expect(note.note).to include 'Canceled the automatic merge'
- end
- end
end