diff options
| author | Rémy Coutable <remy@rymai.me> | 2019-04-08 09:59:30 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2019-04-08 09:59:30 +0000 |
| commit | 6844ba2dcc14c722c149f8b257c7fe73ba4854f4 (patch) | |
| tree | 8ae1b6be4a5b60004ede9a5e3578f51eb8e92b9a | |
| parent | 10cd5fdb7b40fe84c92c1883a8c346e1996abe75 (diff) | |
| parent | dea11717249b98383e4c5435b885287230680616 (diff) | |
| download | gitlab-ce-6844ba2dcc14c722c149f8b257c7fe73ba4854f4.tar.gz | |
Merge branch '60035-weight-trainee-maintainers-higher-in-reviewer-roulette' into 'master'
Resolve "Weight trainee maintainers higher in reviewer roulette"
Closes #60035
See merge request gitlab-org/gitlab-ce!27043
| -rw-r--r-- | danger/roulette/Dangerfile | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/danger/roulette/Dangerfile b/danger/roulette/Dangerfile index 3a4625c4eb6..81ee0397bdc 100644 --- a/danger/roulette/Dangerfile +++ b/danger/roulette/Dangerfile @@ -31,13 +31,15 @@ MARKDOWN def spin(team, project, category) reviewers = team.select { |member| member.reviewer?(project, category) } + traintainers = team.select { |member| member.traintainer?(project, category) } maintainers = team.select { |member| member.maintainer?(project, category) } # TODO: filter out people who are currently not in the office # TODO: take CODEOWNERS into account? - reviewer = reviewers[rand(reviewers.size)] - maintainer = maintainers[rand(maintainers.size)] + # Make traintainers have triple the chance to be picked as a reviewer + reviewer = (reviewers + traintainers + traintainers).sample + maintainer = maintainers.sample "| #{helper.label_for_category(category)} | #{reviewer&.markdown_name} | #{maintainer&.markdown_name} |" end |