Add TODOs to refactoried variables collections code

2 files changed, 5 insertions, 0 deletions

diff --git a/lib/gitlab/ci/variables/collection.rb b/lib/gitlab/ci/variables/collection.rb
index ae7415fcdb1..97ca6dc3d3d 100644
--- a/lib/gitlab/ci/variables/collection.rb
+++ b/lib/gitlab/ci/variables/collection.rb
@@ -14,6 +14,7 @@ module Gitlab
           @variables.append(Collection::Item.fabricate(resource))
         end
 
+        # TODO, specs
         def concat(resources)
           resources.each { |variable| self.append(variable) }
         end
diff --git a/lib/gitlab/ci/variables/collection/item.rb b/lib/gitlab/ci/variables/collection/item.rb
index c238ac8f18e..d6540e86fc5 100644
--- a/lib/gitlab/ci/variables/collection/item.rb
+++ b/lib/gitlab/ci/variables/collection/item.rb
@@ -3,6 +3,8 @@ module Gitlab
     module Variables
       class Collection
         class Item
+          # TODO, public by default?
+          #
           def initialize(**options)
             @variable = {
               key: options.fetch(:key),
@@ -28,6 +30,8 @@ module Gitlab
           end
 
           def self.fabricate(resource)
+            # TODO, to_runner_variable by default for class < ActiveRecord::Base
+            #
             case resource
             when Hash
               self.new(resource)