summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnwar El Wakil <anwar_elwakil@outlook.com>2018-01-19 13:15:35 +0000
committerAnwar El Wakil <anwar_elwakil@outlook.com>2018-01-19 13:15:35 +0000
commit408e3cc1c43e7e09c96c40cb5e0c048b6cb8d154 (patch)
tree3651d3177a38a330392bc8d278264b99064e02f4
parentbd24529131484f6daee150303f634c2f2f901767 (diff)
downloadgitlab-ce-408e3cc1c43e7e09c96c40cb5e0c048b6cb8d154.tar.gz
Update best_practices.md
Remove duplicate list item in "General Guidelines" Section.
-rw-r--r--doc/development/testing_guide/best_practices.md1
1 files changed, 0 insertions, 1 deletions
diff --git a/doc/development/testing_guide/best_practices.md b/doc/development/testing_guide/best_practices.md
index edb8f372ea3..f5e8b4f146f 100644
--- a/doc/development/testing_guide/best_practices.md
+++ b/doc/development/testing_guide/best_practices.md
@@ -26,7 +26,6 @@ Here are some things to keep in mind regarding test performance:
- Use `.method` to describe class methods and `#method` to describe instance
methods.
- Use `context` to test branching logic.
-- Don't assert against the absolute value of a sequence-generated attribute (see [Gotchas](../gotchas.md#dont-assert-against-the-absolute-value-of-a-sequence-generated-attribute)).
- Try to match the ordering of tests to the ordering within the class.
- Try to follow the [Four-Phase Test][four-phase-test] pattern, using newlines
to separate phases.