diff options
author | Phil Hughes <me@iamphill.com> | 2018-05-11 07:37:49 +0000 |
---|---|---|
committer | Phil Hughes <me@iamphill.com> | 2018-05-11 07:37:49 +0000 |
commit | e1abca20db327958d635a09454999f4e256f7cf6 (patch) | |
tree | 1224fab64e19cb7985619e8f6de2c51756d94513 | |
parent | 023ac1ec2bd634d1f50411f0f97c73675f581360 (diff) | |
parent | f1abb88e7bcd127e957914d0739534201e3c77d6 (diff) | |
download | gitlab-ce-e1abca20db327958d635a09454999f4e256f7cf6.tar.gz |
Merge branch '40725-move-mr-external-link-to-right' into 'master'
Resolve "Move external link icon to end of link instead of front"
Closes #40725
See merge request gitlab-org/gitlab-ce!18828
-rw-r--r-- | app/assets/javascripts/vue_merge_request_widget/components/deployment.vue | 2 | ||||
-rw-r--r-- | changelogs/unreleased/40725-move-mr-external-link-to-right.yml | 5 |
2 files changed, 6 insertions, 1 deletions
diff --git a/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue b/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue index 7bef2e97349..1fea231c816 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue @@ -109,12 +109,12 @@ export default { rel="noopener noreferrer nofollow" class="deploy-link js-deploy-url" > + {{ deployment.external_url_formatted }} <i class="fa fa-external-link" aria-hidden="true" > </i> - {{ deployment.external_url_formatted }} </a> </template> <span diff --git a/changelogs/unreleased/40725-move-mr-external-link-to-right.yml b/changelogs/unreleased/40725-move-mr-external-link-to-right.yml new file mode 100644 index 00000000000..e3ebeb5eb61 --- /dev/null +++ b/changelogs/unreleased/40725-move-mr-external-link-to-right.yml @@ -0,0 +1,5 @@ +--- +title: Moves MR widget external link icon to the right +merge_request: 18828 +author: Jacopo Beschi @jacopo-beschi +type: changed |