diff options
| author | Robert Speicher <robert@gitlab.com> | 2016-03-22 21:00:48 +0000 |
|---|---|---|
| committer | Robert Speicher <robert@gitlab.com> | 2016-03-22 21:00:48 +0000 |
| commit | 57dd206f12524807403a6f3146bde0e31ead79a9 (patch) | |
| tree | 4b61f56895e1291a5a8e9dd1fdb74261bf7d92da | |
| parent | 62ffdbeb2d5699d6e70f3270ad549c75f5dbdd20 (diff) | |
| parent | 8d7ad53561f2e49365827d086bd1c5ec2b0ce5e7 (diff) | |
| download | gitlab-ce-57dd206f12524807403a6f3146bde0e31ead79a9.tar.gz | |
Merge branch 'css-selector-format' into 'master'
Disabled SelectorFormat rule for SCSS Lint in order to get the Rake
task passing sooner.
SelectorFormat enforces that CSS classes and IDs use lowercase
hyphenated style, `like-this`, but a not-insignificant amount of
selectors in the codebase are `like_this`.
Fixing the selectors that break this rule would require changing HTML
as well, and potentially break JavaScript hooks, among other things. So
I decided to disable this rule for the time being, hopefully making it
easier to fix all the remaining warnings SCSS Lint is giving by removing
the most problematic rule.
Discussed in #14299.
See merge request !3309
| -rw-r--r-- | .scss-lint.yml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.scss-lint.yml b/.scss-lint.yml index e350b2073c3..937d3407b60 100644 --- a/.scss-lint.yml +++ b/.scss-lint.yml @@ -100,7 +100,7 @@ linters: # Selectors should always use hyphenated-lowercase, rather than camelCase or # snake_case. SelectorFormat: - enabled: true + enabled: false convention: hyphenated_lowercase # Prefer the shortest shorthand form possible for properties that support it. |