summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKamil Trzciński <ayufan@ayufan.eu>2016-12-22 15:26:08 +0000
committerKamil Trzciński <ayufan@ayufan.eu>2016-12-22 15:26:08 +0000
commitfbd8fd883bfc1c1c6e5fda132c8759c608fa7980 (patch)
tree95020215773549bc96dfa07348dbb205bb1533a3
parentf3a5409c581dc79262fe60d1c38d68f654338e20 (diff)
parent4b7395e0fab8e35436957e41929b44f948a1c41a (diff)
downloadgitlab-ce-fbd8fd883bfc1c1c6e5fda132c8759c608fa7980.tar.gz
Merge branch 'zj-slack-404-error' into 'master'
Fix format of Slack when result is nil Closes #25954 See merge request !8248
-rw-r--r--app/models/project_services/slack_slash_commands_service.rb2
-rw-r--r--spec/models/project_services/slack_slash_commands_service_spec.rb (renamed from spec/models/project_services/slack_slash_commands_service.rb)3
2 files changed, 3 insertions, 2 deletions
diff --git a/app/models/project_services/slack_slash_commands_service.rb b/app/models/project_services/slack_slash_commands_service.rb
index cb19ebf4cad..5a7cc0fb329 100644
--- a/app/models/project_services/slack_slash_commands_service.rb
+++ b/app/models/project_services/slack_slash_commands_service.rb
@@ -16,7 +16,7 @@ class SlackSlashCommandsService < ChatSlashCommandsService
def trigger(params)
# Format messages to be Slack-compatible
super.tap do |result|
- result[:text] = format(result[:text])
+ result[:text] = format(result[:text]) if result.is_a?(Hash)
end
end
diff --git a/spec/models/project_services/slack_slash_commands_service.rb b/spec/models/project_services/slack_slash_commands_service_spec.rb
index 5775e439906..5766aa340e2 100644
--- a/spec/models/project_services/slack_slash_commands_service.rb
+++ b/spec/models/project_services/slack_slash_commands_service_spec.rb
@@ -18,7 +18,8 @@ describe SlackSlashCommandsService, :models do
let(:service) do
project.create_slack_slash_commands_service(
- properties: { token: 'token' }
+ properties: { token: 'token' },
+ active: true
)
end