diff options
author | Jacob Schatz <jschatz@gitlab.com> | 2018-03-02 19:59:45 +0000 |
---|---|---|
committer | Jacob Schatz <jschatz@gitlab.com> | 2018-03-02 19:59:45 +0000 |
commit | ddad22c4c4fde6dbec4a9224a3c2500af8bc7bf0 (patch) | |
tree | 5fce92462fb8aa038739269851fae833f262c2ed | |
parent | c9660b45b19287775068dc7109b711c10b4c8867 (diff) | |
parent | 8510fc8701344afdfc76e4df7f97b686175dae70 (diff) | |
download | gitlab-ce-ddad22c4c4fde6dbec4a9224a3c2500af8bc7bf0.tar.gz |
Merge branch 'terminal-bundle-refactor' into 'master'
Removed terminal webpack bundle tag
See merge request gitlab-org/gitlab-ce!17494
-rw-r--r-- | app/assets/javascripts/pages/projects/environments/terminal/index.js | 3 | ||||
-rw-r--r-- | app/assets/javascripts/terminal/index.js (renamed from app/assets/javascripts/terminal/terminal_bundle.js) | 2 | ||||
-rw-r--r-- | app/views/projects/environments/terminal.html.haml | 1 | ||||
-rw-r--r-- | config/webpack.config.js | 1 |
4 files changed, 4 insertions, 3 deletions
diff --git a/app/assets/javascripts/pages/projects/environments/terminal/index.js b/app/assets/javascripts/pages/projects/environments/terminal/index.js new file mode 100644 index 00000000000..7129e24cee1 --- /dev/null +++ b/app/assets/javascripts/pages/projects/environments/terminal/index.js @@ -0,0 +1,3 @@ +import initTerminal from '~/terminal/'; + +document.addEventListener('DOMContentLoaded', initTerminal); diff --git a/app/assets/javascripts/terminal/terminal_bundle.js b/app/assets/javascripts/terminal/index.js index 134522ef961..1a75e072c4e 100644 --- a/app/assets/javascripts/terminal/terminal_bundle.js +++ b/app/assets/javascripts/terminal/index.js @@ -6,4 +6,4 @@ import './terminal'; window.Terminal = Terminal; -$(() => new gl.Terminal({ selector: '#terminal' })); +export default () => new gl.Terminal({ selector: '#terminal' }); diff --git a/app/views/projects/environments/terminal.html.haml b/app/views/projects/environments/terminal.html.haml index 7be4ef39117..6ec4ff56552 100644 --- a/app/views/projects/environments/terminal.html.haml +++ b/app/views/projects/environments/terminal.html.haml @@ -3,7 +3,6 @@ - content_for :page_specific_javascripts do = stylesheet_link_tag "xterm/xterm" - = webpack_bundle_tag("terminal") %div{ class: container_class } .top-area diff --git a/config/webpack.config.js b/config/webpack.config.js index 959cebe7487..0fedb6a8c72 100644 --- a/config/webpack.config.js +++ b/config/webpack.config.js @@ -45,7 +45,6 @@ function generateEntries() { const manualEntries = { monitoring: './monitoring/monitoring_bundle.js', mr_notes: './mr_notes/index.js', - terminal: './terminal/terminal_bundle.js', common: './commons/index.js', common_vue: './vue_shared/vue_resource_interceptor.js', |