diff options
| author | Jacob Vosmaer <contact@jacobvosmaer.nl> | 2014-02-25 11:58:22 +0100 |
|---|---|---|
| committer | Jacob Vosmaer <contact@jacobvosmaer.nl> | 2014-02-25 11:58:22 +0100 |
| commit | 8016cefafe97d3a143cf21b270c110d357e46273 (patch) | |
| tree | e00de389d4914bd1f3be3d05f6c50d23ab592735 | |
| parent | 0432bdf19eb3483e109582832a36dc7a3601a384 (diff) | |
| download | gitlab-ce-8016cefafe97d3a143cf21b270c110d357e46273.tar.gz | |
Make the Gitlab::Popen path argument optional
| -rw-r--r-- | lib/gitlab/popen.rb | 3 | ||||
| -rw-r--r-- | spec/lib/gitlab/popen_spec.rb | 9 |
2 files changed, 11 insertions, 1 deletions
diff --git a/lib/gitlab/popen.rb b/lib/gitlab/popen.rb index d10269f4438..f9559012c4a 100644 --- a/lib/gitlab/popen.rb +++ b/lib/gitlab/popen.rb @@ -3,11 +3,12 @@ require 'open3' module Gitlab module Popen - def popen(cmd, path) + def popen(cmd, path=nil) unless cmd.is_a?(Array) raise "System commands must be given as an array of strings" end + path ||= Dir.pwd vars = { "PWD" => path } options = { chdir: path } diff --git a/spec/lib/gitlab/popen_spec.rb b/spec/lib/gitlab/popen_spec.rb index a4a0846b7b9..76d506eb3c0 100644 --- a/spec/lib/gitlab/popen_spec.rb +++ b/spec/lib/gitlab/popen_spec.rb @@ -32,5 +32,14 @@ describe 'Gitlab::Popen', no_db: true do end end + context 'without a directory argument' do + before do + @output, @status = @klass.new.popen(%W(ls)) + end + + it { @status.should be_zero } + it { @output.should include('spec') } + end + end |
