summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShinya Maeda <shinya@gitlab.com>2018-10-17 14:57:24 +0900
committerShinya Maeda <shinya@gitlab.com>2018-10-17 14:57:24 +0900
commita8db4390e0b7ab69b67ef23f2a89759b35e3eb74 (patch)
tree6042a77855aa46a8d1d03ba0f26f8d4fb0a07ded
parente68a8a73f87cd1834c1f9c27f7f5c389c8e5af43 (diff)
parentb593f2ef15546567165cfb61c737aa0d31ff1012 (diff)
downloadgitlab-ce-a8db4390e0b7ab69b67ef23f2a89759b35e3eb74.tar.gz
Merge branch 'use-deployment-status-in-job-log-page' into expose-deployment-status-for-mr-widget
-rw-r--r--app/models/ci/build.rb27
-rw-r--r--app/serializers/build_details_entity.rb19
2 files changed, 0 insertions, 46 deletions
diff --git a/app/models/ci/build.rb b/app/models/ci/build.rb
index c5e6e0d46d2..94c1205a22e 100644
--- a/app/models/ci/build.rb
+++ b/app/models/ci/build.rb
@@ -700,23 +700,6 @@ module Ci
end
end
- # Virtual deployment status depending on the environment status.
- # def deployment_status
- # last_deployment.detailed_status
- # end
-
- # def deployment_status
- # return nil unless starts_environment?
-
- # if success?
- # return successful_deployment_status
- # elsif complete? && !success?
- # return :failed
- # end
-
- # :creating
- # end
-
private
def erase_old_artifacts!
@@ -726,16 +709,6 @@ module Ci
save
end
- def successful_deployment_status
- if success? && last_deployment&.last?
- return :last
- elsif success? && last_deployment.present?
- return :out_of_date
- end
-
- :creating
- end
-
def each_report(report_types)
job_artifacts_for_types(report_types).each do |report_artifact|
report_artifact.each_blob do |blob|
diff --git a/app/serializers/build_details_entity.rb b/app/serializers/build_details_entity.rb
index bbcfa5ab346..ff910e8625c 100644
--- a/app/serializers/build_details_entity.rb
+++ b/app/serializers/build_details_entity.rb
@@ -8,27 +8,8 @@ class BuildDetailsEntity < JobEntity
expose :user, using: UserEntity
expose :runner, using: RunnerEntity
expose :pipeline, using: PipelineEntity
-
-<<<<<<< HEAD
expose :deployment_status, with: DetailedStatusEntity
- # expose :deployment_status, if: -> (*) { build.starts_environment? } do
- # expose :deployment_status, as: :status
-
- # expose :persisted_environment, as: :environment, with: EnvironmentEntity
- # end
-=======
- expose :deployment_status, with: DetailedStatusEntity do |build|
- build.last_deployment.detailed_status
- end
->>>>>>> Use deployment status in job log page
-
- # expose :deployment_status, if: -> (*) { build.starts_environment? } do
- # expose :deployment_status, as: :status
-
- # expose :persisted_environment, as: :environment, with: EnvironmentEntity
- # end
-
expose :metadata, using: BuildMetadataEntity
expose :artifact, if: -> (*) { can?(current_user, :read_build, build) } do