summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDouwe Maan <douwe@gitlab.com>2018-10-15 16:16:40 +0000
committerDouwe Maan <douwe@gitlab.com>2018-10-15 16:16:40 +0000
commit422715b2248535be9521c6499b94090ac90b394c (patch)
tree14673045465ab80139c3c0c83c7f8d370c0ec78f
parentf5d088eb11b066dadad06948e158b39e9432573c (diff)
parent189f366b9c9c3c0995bf4c6d82f76c77154f247b (diff)
downloadgitlab-ce-422715b2248535be9521c6499b94090ac90b394c.tar.gz
Merge branch 'ready-for-review-doc' into 'master'
Add documentation how to assign a merge request for review See merge request gitlab-org/gitlab-ce!21327
-rw-r--r--doc/development/code_review.md16
1 files changed, 15 insertions, 1 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md
index edf0b6f46df..87437dd7720 100644
--- a/doc/development/code_review.md
+++ b/doc/development/code_review.md
@@ -29,7 +29,7 @@ There are a few rules to get your merge request accepted:
to ask one of the [Merge request coaches][team].
1. It is recommended that you assign a maintainer that is from a different team than your own.
This ensures that all code across GitLab is consistent and can be easily understood by all contributors.
-
+
1. Keep in mind that maintainers are also going to perform a final code review.
The ideal scenario is that the reviewer has already addressed any concerns
the maintainer would have found, and the maintainer only has to perform the
@@ -97,6 +97,20 @@ first time.
branch. Do not squash until the branch is ready to merge. Reviewers should be
able to read individual updates based on their earlier feedback.
+### Assigning a merge request for a review
+
+If you want to have your merge request reviewed you can assign it to any reviewer. The list of reviewers can be found on [Engineering projects](https://about.gitlab.com/handbook/engineering/projects/) page.
+
+You can also use `ready for review` label. That means that your merge request is ready to be reviewed and any reviewer can pick it. It is recommended to use that label only if there isn't time pressure and make sure the merge request is assigned to a reviewer.
+
+When your merge request was reviewed and can be passed to a maintainer you can either pick a specific maintainer or use a label `ready for merge`.
+
+It is responsibility of the author of a merge request that the merge request is reviewed. If it stays in `ready for review` state too long it is recommended to assign it to a specific reviewer.
+
+### List of merge requests ready for review
+
+Developers who have capacity can regularly check the list of [merge requests to review](https://gitlab.com/groups/gitlab-org/-/merge_requests?scope=all&utf8=%E2%9C%93&state=opened&label_name%5B%5D=ready%20for%20review&assignee_id=0) and assign any merge request they want to review.
+
### Reviewing code
Understand why the change is necessary (fixes a bug, improves the user