summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoão Cunha <j.a.cunha@gmail.com>2019-09-11 21:08:43 +0100
committerJoão Cunha <j.a.cunha@gmail.com>2019-09-11 21:11:01 +0100
commitb4e7a87c674b790a036518cecb20a4ddd3bdc47e (patch)
treec5e99694e5ae2a124343c19f3b3fc8f1050f7d25
parent0de815490573b190999c598fa664ca243d28b64a (diff)
downloadgitlab-ce-b4e7a87c674b790a036518cecb20a4ddd3bdc47e.tar.gz
Give removing status priority on cluster status_name
-rw-r--r--app/models/clusters/cluster.rb2
-rw-r--r--spec/models/clusters/cluster_spec.rb16
2 files changed, 9 insertions, 9 deletions
diff --git a/app/models/clusters/cluster.rb b/app/models/clusters/cluster.rb
index b1d10d6e402..43462e4bf4d 100644
--- a/app/models/clusters/cluster.rb
+++ b/app/models/clusters/cluster.rb
@@ -120,7 +120,7 @@ module Clusters
end
def status_name
- provider&.status_name || connection_status.presence || removing_status || :created
+ removing_status || provider&.status_name || connection_status.presence || :created
end
def connection_status
diff --git a/spec/models/clusters/cluster_spec.rb b/spec/models/clusters/cluster_spec.rb
index 2875a55f749..ec1cfe4c1c5 100644
--- a/spec/models/clusters/cluster_spec.rb
+++ b/spec/models/clusters/cluster_spec.rb
@@ -660,6 +660,14 @@ describe Clusters::Cluster, :use_clean_rails_memory_store_caching do
end
it { is_expected.to eq :errored }
+
+ context 'when cluster is removing' do
+ it "returns removing since this info has priority" do
+ cluster.removing!
+
+ is_expected.to eq :removing
+ end
+ end
end
context 'there is a cached connection status' do
@@ -680,14 +688,6 @@ describe Clusters::Cluster, :use_clean_rails_memory_store_caching do
end
it { is_expected.to eq :created }
-
- context 'when cluster is removing' do
- it 'returns removing' do
- cluster.removing!
-
- is_expected.to eq :removing
- end
- end
end
end