diff options
| author | Rémy Coutable <remy@rymai.me> | 2018-05-14 15:22:21 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2018-05-14 15:22:21 +0000 |
| commit | 801c377c7320707287072282c13b8182bbfc91ff (patch) | |
| tree | 6f14ac5cabfba8f69b52de25f784e9cf8c71a78f | |
| parent | c6e92e607c4bddc5cf9a87d25ed647d6debd01f7 (diff) | |
| parent | 2543a0a942c60a3581dd35bae6d4fa1ee8ee70c0 (diff) | |
| download | gitlab-ce-801c377c7320707287072282c13b8182bbfc91ff.tar.gz | |
Merge branch '46297_improve_code_review_section_in_mr_templates' into 'master'
Improve the code review section in MR templates.
See merge request gitlab-org/gitlab-ce!18920
| -rw-r--r-- | .gitlab/merge_request_templates/Database Changes.md | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/.gitlab/merge_request_templates/Database Changes.md b/.gitlab/merge_request_templates/Database Changes.md index 2bb1f374e98..b81900f67e1 100644 --- a/.gitlab/merge_request_templates/Database Changes.md +++ b/.gitlab/merge_request_templates/Database Changes.md @@ -37,9 +37,9 @@ When removing columns, tables, indexes or other structures: - [ ] [Documentation created/updated](https://docs.gitlab.com/ee/development/doc_styleguide.html) - [ ] API support added - [ ] Tests added for this feature/bug -- Review - - [ ] Has been reviewed by Backend - - [ ] Has been reviewed by Database +- Conform by the [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html) + - [ ] Has been reviewed by a Backend maintainer + - [ ] Has been reviewed by a Database specialist - [ ] Conform by the [merge request performance guides](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/CONTRIBUTING.md#style-guides) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) |