diff options
author | Mark Lapierre <mlapierre@gitlab.com> | 2019-06-06 04:27:36 +0000 |
---|---|---|
committer | Mark Lapierre <mlapierre@gitlab.com> | 2019-06-06 04:27:36 +0000 |
commit | 11bb3b53bcd2b50cb3fe243ac3b778354849cdde (patch) | |
tree | 399182c462a3ca28282f9f3f281636dba6795dbb | |
parent | 55920e074c2352e41394eca63d5b7fb03284e352 (diff) | |
parent | 4dc7a157aaf062de85e4c65add8446f7d5f8823c (diff) | |
download | gitlab-ce-11bb3b53bcd2b50cb3fe243ac3b778354849cdde.tar.gz |
Merge branch 'qa-ml-retry-first-login-validation' into 'master'
[CE] Retry the first login page validation
Closes gitlab-org/quality/nightly#103
See merge request gitlab-org/gitlab-ce!29100
-rw-r--r-- | qa/qa/ce/strategy.rb | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/qa/qa/ce/strategy.rb b/qa/qa/ce/strategy.rb index 7e2d02424fe..6c1820ffdc8 100644 --- a/qa/qa/ce/strategy.rb +++ b/qa/qa/ce/strategy.rb @@ -10,9 +10,18 @@ module QA end def perform_before_hooks + retries ||= 0 + # The login page could take some time to load the first time it is visited. # We visit the login page and wait for it to properly load only once before the tests. QA::Runtime::Browser.visit(:gitlab, QA::Page::Main::Login) + rescue QA::Page::Validatable::PageValidationError + if (retries += 1) < 3 + Runtime::Logger.warn("The login page did not appear as expected. Retrying... (attempt ##{retries})") + retry + end + + raise end end end |