summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDouwe Maan <douwe@gitlab.com>2017-07-07 20:19:35 +0000
committerShinya Maeda <shinya@gitlab.com>2017-07-10 16:43:34 +0900
commit0c76377bed1427433028d9dc568cb0e4088d3a3d (patch)
tree51378a82874207deeebafa3016edb85fe3e96747
parent95779ee87f5046fc6bed3c2a7bc9354afcf972ee (diff)
downloadgitlab-ce-0c76377bed1427433028d9dc568cb0e4088d3a3d.tar.gz
Merge branch 'rs-issue-34847' into 'master'
Mark a subgroup-related spec as PostgreSQL-only Closes #34847 See merge request !12722
-rw-r--r--spec/models/group_spec.rb20
1 files changed, 13 insertions, 7 deletions
diff --git a/spec/models/group_spec.rb b/spec/models/group_spec.rb
index 89ae9b3aa5b..c927c129eb4 100644
--- a/spec/models/group_spec.rb
+++ b/spec/models/group_spec.rb
@@ -506,15 +506,21 @@ describe Group, models: true do
end
end
- context 'when group has children' do
- let!(:variable) { create(:ci_group_variable, group: group) }
- let!(:group_child) { create(:group, parent: group) }
- let!(:variable_child) { create(:ci_group_variable, group: group_child) }
-
- subject { group_child.secret_variables_for('ref', project) }
+ context 'when group has children', :postgresql do
+ let(:group_child) { create(:group, parent: group) }
+ let(:group_child_2) { create(:group, parent: group_child) }
+ let(:group_child_3) { create(:group, parent: group_child_2) }
+ let(:variable_child) { create(:ci_group_variable, group: group_child) }
+ let(:variable_child_2) { create(:ci_group_variable, group: group_child_2) }
+ let(:variable_child_3) { create(:ci_group_variable, group: group_child_3) }
it 'returns all variables belong to the group and parent groups' do
- is_expected.to eq([variable, variable_child])
+ expected_array1 = [protected_variable, secret_variable]
+ expected_array2 = [variable_child, variable_child_2, variable_child_3]
+ got_array = group_child_3.secret_variables_for('ref', project).to_a
+
+ expect(got_array.shift(2)).to contain_exactly(*expected_array1)
+ expect(got_array).to eq(expected_array2)
end
end
end