summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShinya Maeda <shinya@gitlab.com>2017-09-02 17:06:25 +0900
committerShinya Maeda <shinya@gitlab.com>2017-09-05 14:30:28 +0900
commit69df47c7e43e1661faf97eb6d2b287a346215c31 (patch)
tree0bcd9ea0cb5638d7266fc7d3ac744272a4246ff0
parente8e8ae4d7df1de71d9f52e774607ac1ba4cce1cc (diff)
downloadgitlab-ce-69df47c7e43e1661faf97eb6d2b287a346215c31.tar.gz
Improve spec
-rw-r--r--spec/workers/stuck_ci_jobs_worker_spec.rb21
1 files changed, 12 insertions, 9 deletions
diff --git a/spec/workers/stuck_ci_jobs_worker_spec.rb b/spec/workers/stuck_ci_jobs_worker_spec.rb
index 41549a77495..ac6f4fefb4e 100644
--- a/spec/workers/stuck_ci_jobs_worker_spec.rb
+++ b/spec/workers/stuck_ci_jobs_worker_spec.rb
@@ -6,28 +6,31 @@ describe StuckCiJobsWorker do
let(:worker) { described_class.new }
let(:exclusive_lease_uuid) { SecureRandom.uuid }
- subject do
- job.reload
- job.status
- end
-
before do
job.update!(status: status, updated_at: updated_at)
allow_any_instance_of(Gitlab::ExclusiveLease).to receive(:try_obtain).and_return(exclusive_lease_uuid)
end
shared_examples 'job is dropped' do
- it 'changes status' do
+ before do
worker.perform
- is_expected.to eq('failed')
+ job.reload
+ end
+
+ it "changes status" do
+ expect(job).to be_failed
expect(job).to be_stuck_or_timeout_failure
end
end
shared_examples 'job is unchanged' do
- it "doesn't change status" do
+ before do
worker.perform
- is_expected.to eq(status)
+ job.reload
+ end
+
+ it "doesn't change status" do
+ expect(job.status).to eq(status)
end
end