properly remove events and get rid of lingering interval loops

1 files changed, 4 insertions, 12 deletions

diff --git a/app/assets/javascripts/vue_pipelines_index/store.js.es6 b/app/assets/javascripts/vue_pipelines_index/store.js.es6
index 04fde27af58..d7ae9255e9a 100644
--- a/app/assets/javascripts/vue_pipelines_index/store.js.es6
+++ b/app/assets/javascripts/vue_pipelines_index/store.js.es6
@@ -49,28 +49,20 @@
 
       startTimeLoops();
 
-      const removeTimeIntervals = () => {
-        clearInterval(this.timeLoopInterval);
-      };
-
-      const startIntervalLoops = () => {
-        startTimeLoops();
-      };
+      const removeTimeIntervals = () => clearInterval(this.timeLoopInterval);
+      const startIntervalLoops = () => startTimeLoops();
 
       const removeAll = () => {
+        removeTimeIntervals();
         window.removeEventListener('beforeunload', removeTimeIntervals);
         window.removeEventListener('focus', startIntervalLoops);
         window.removeEventListener('blur', removeTimeIntervals);
-
-        // turbolinks event handler
-        document.removeEventListener('page:fetch', () => {});
+        document.removeEventListener('page:fetch', removeAll);
       };
 
       window.addEventListener('beforeunload', removeTimeIntervals);
       window.addEventListener('focus', startIntervalLoops);
       window.addEventListener('blur', removeTimeIntervals);
-
-      // turbolinks event handler
       document.addEventListener('page:fetch', removeAll);
     }
   };