summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGrzegorz Bizon <grzesiek.bizon@gmail.com>2016-03-20 09:28:06 +0100
committerGrzegorz Bizon <grzesiek.bizon@gmail.com>2016-03-20 09:28:06 +0100
commitf0211a4ea9e14293e2aea6f93798f23a01287bed (patch)
treef32c2e5188f8eddc182f7aac866f78314189b8dd
parenta2f25ed60b81f8c0325a7d1e33898351afa1d60f (diff)
downloadgitlab-ce-f0211a4ea9e14293e2aea6f93798f23a01287bed.tar.gz
Do not pass params that are not used in issue move service
-rw-r--r--app/controllers/projects/issues_controller.rb2
-rw-r--r--spec/services/issues/move_service_spec.rb3
2 files changed, 2 insertions, 3 deletions
diff --git a/app/controllers/projects/issues_controller.rb b/app/controllers/projects/issues_controller.rb
index aa73c6df545..a51916720eb 100644
--- a/app/controllers/projects/issues_controller.rb
+++ b/app/controllers/projects/issues_controller.rb
@@ -92,7 +92,7 @@ class Projects::IssuesController < Projects::ApplicationController
if params[:move_to_project_id].to_i > 0
new_project = Project.find(params[:move_to_project_id])
- move_service = Issues::MoveService.new(project, current_user, issue_params)
+ move_service = Issues::MoveService.new(project, current_user)
@issue = move_service.execute(@issue, new_project)
end
diff --git a/spec/services/issues/move_service_spec.rb b/spec/services/issues/move_service_spec.rb
index fd958a44e3e..cd24af88d5f 100644
--- a/spec/services/issues/move_service_spec.rb
+++ b/spec/services/issues/move_service_spec.rb
@@ -7,7 +7,6 @@ describe Issues::MoveService, services: true do
let(:description) { 'Some issue description' }
let(:old_project) { create(:project) }
let(:new_project) { create(:project) }
- let(:issue_params) { old_issue.serializable_hash }
let(:old_issue) do
create(:issue, title: title, description: description,
@@ -15,7 +14,7 @@ describe Issues::MoveService, services: true do
end
let(:move_service) do
- described_class.new(old_project, user, issue_params)
+ described_class.new(old_project, user)
end
shared_context 'user can move issue' do