diff options
author | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2018-07-12 12:31:33 +0200 |
---|---|---|
committer | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2018-07-12 12:31:33 +0200 |
commit | af00a1591412655202a634fbca999b80b97a676e (patch) | |
tree | feab26c527a496b971334347385d1bd242b1aebc | |
parent | e270366d844d27ba55b96fb589b8505502c76a08 (diff) | |
download | gitlab-ce-af00a1591412655202a634fbca999b80b97a676e.tar.gz |
Remove unused `stop_action?` method from deployment classfix/gb/rename-environments-stop-actions
-rw-r--r-- | app/models/deployment.rb | 4 | ||||
-rw-r--r-- | spec/models/deployment_spec.rb | 18 |
2 files changed, 0 insertions, 22 deletions
diff --git a/app/models/deployment.rb b/app/models/deployment.rb index ac86e9e8de0..687246b47b2 100644 --- a/app/models/deployment.rb +++ b/app/models/deployment.rb @@ -92,10 +92,6 @@ class Deployment < ActiveRecord::Base @stop_action ||= manual_actions.find_by(name: on_stop) end - def stop_action? - stop_action.present? - end - def formatted_deployment_time created_at.to_time.in_time_zone.to_s(:medium) end diff --git a/spec/models/deployment_spec.rb b/spec/models/deployment_spec.rb index e01906f4b6c..b335e0fbeb3 100644 --- a/spec/models/deployment_spec.rb +++ b/spec/models/deployment_spec.rb @@ -157,22 +157,4 @@ describe Deployment do end end end - - describe '#stop_action?' do - subject { deployment.stop_action? } - - context 'when no other actions' do - let(:deployment) { build(:deployment) } - - it { is_expected.to be_falsey } - end - - context 'when matching action is defined' do - let(:build) { create(:ci_build) } - let(:deployment) { FactoryBot.build(:deployment, deployable: build, on_stop: 'close_app') } - let!(:close_action) { create(:ci_build, :manual, pipeline: build.pipeline, name: 'close_app') } - - it { is_expected.to be_truthy } - end - end end |