diff options
| author | Jacob Schatz <jschatz@gitlab.com> | 2017-09-20 02:19:00 +0000 |
|---|---|---|
| committer | Jacob Schatz <jschatz@gitlab.com> | 2017-09-20 02:19:00 +0000 |
| commit | 2608e269a528290db1bc6d6c0d97b71b5bc3ff26 (patch) | |
| tree | a54bbc3ace92cb5efb53225f216d2e26417bfc39 | |
| parent | 2372bfa9925a34fdbd30f8c7c474b91025395dd5 (diff) | |
| parent | 9ba8685ea701a2f805d4bf6fb71ff52c49065c92 (diff) | |
| download | gitlab-ce-2608e269a528290db1bc6d6c0d97b71b5bc3ff26.tar.gz | |
Merge branch 'docs-specific-review-examples' into 'master'
Add specific code review guidelines
See merge request gitlab-org/gitlab-ce!13206
| -rw-r--r-- | doc/development/code_review.md | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 64a89976300..7165b8062a7 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -9,8 +9,18 @@ There are a few rules to get your merge request accepted: **approved by a [backend maintainer][projects]**. 1. If your merge request includes only frontend changes [^1], it must be **approved by a [frontend maintainer][projects]**. + 1. If your merge request includes UX changes [^1], it must + be **approved by a [UX team member][team]**. + 1. If your merge request includes adding a new JavaScript library [^1], it must be + **approved by a [frontend lead][team]**. + 1. If your merge request includes adding a new UI/UX paradigm [^1], it must be + **approved by a [UX lead][team]**. 1. If your merge request includes frontend and backend changes [^1], it must be **approved by a [frontend and a backend maintainer][projects]**. + 1. If your merge request includes UX and frontend changes [^1], it must + be **approved by a [UX team member and a frontend maintainer][team]**. + 1. If your merge request includes UX, frontend and backend changes [^1], it must + be **approved by a [UX team member, a frontend and a backend maintainer][team]**. 1. If your merge request includes a new dependency or a filesystem change, it must be **approved by a [Build team member][team]**. See [how to work with the Build team][build handbook] for more details. 1. To lower the amount of merge requests maintainers need to review, you can |