restructure the #new_key notification spec

1 files changed, 6 insertions, 11 deletions

diff --git a/spec/services/notification_service_spec.rb b/spec/services/notification_service_spec.rb
index d7ac0746df4..44d3f441382 100644
--- a/spec/services/notification_service_spec.rb
+++ b/spec/services/notification_service_spec.rb
@@ -80,21 +80,16 @@ describe NotificationService, :mailer do
 
   describe 'Keys' do
     describe '#new_key' do
-      let!(:key) { create(:personal_key) }
+      let(:key_options) { {} }
+      let!(:key) { create(:personal_key, key_options) }
 
       it { expect(notification.new_key(key)).to be_truthy }
+      it { should_email(key.user) }
 
-      it 'sends email to key owner' do
-        expect { notification.new_key(key) }.to change { ActionMailer::Base.deliveries.size }.by(1)
-      end
-
-      it 'never emails the ghost user' do
-        key.user = User.ghost
-
-        reset_delivered_emails!
-        notification.new_key(key)
+      describe 'never emails the ghost user' do
+        let(:key_options) { { user: User.ghost } }
 
-        should_not_email_anyone
+        it { should_not_email_anyone }
       end
     end
   end