diff options
| author | Mark Pundsack <markpundsack@users.noreply.github.com> | 2016-06-07 22:09:15 -0700 |
|---|---|---|
| committer | Mark Pundsack <markpundsack@users.noreply.github.com> | 2016-06-13 22:06:13 -0700 |
| commit | 6841e76b45b44da9f749538dbae2bb1fc63d8ee4 (patch) | |
| tree | 3dab77dce19c50501d0150d5c294069af61689da | |
| parent | d7664c7223cbd9e91e21beaf6ceb9ea7c2f294d8 (diff) | |
| download | gitlab-ce-6841e76b45b44da9f749538dbae2bb1fc63d8ee4.tar.gz | |
Add notes
| -rw-r--r-- | doc/ci/docker/using_docker_build.md | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/doc/ci/docker/using_docker_build.md b/doc/ci/docker/using_docker_build.md index fe2c5207cd1..a5f37366265 100644 --- a/doc/ci/docker/using_docker_build.md +++ b/doc/ci/docker/using_docker_build.md @@ -280,5 +280,11 @@ deploy: - master ``` +Notes: +1. You must log in to the container registry before running commands. Putting this in `before_script` will run it before each build job. +1. Using `docker build --pull` makes sure that Docker fetches any changes to base images before building just in case your cache is stale. It takes slightly longer, but means you don’t get stuck without security patches to base images. +1. Doing an explicit `docker pull` before each `docker run` makes sure to fetch the latest image that was just built. This is especially important if you are using multiple runners that cache images locally. Using the git SHA in your image tag makes this less necessary since each build will be unique and you shouldn't ever have a stale image, but it's still possible if you re-build a given commit after a dependency has changed. +1. You don't want to build directly to `latest` in case there are multiple builds happening simultaneously. + [docker-in-docker]: https://blog.docker.com/2013/09/docker-can-now-run-within-docker/ [docker-cap]: https://docs.docker.com/engine/reference/run/#runtime-privilege-and-linux-capabilities |