diff options
author | James Lopez <james@gitlab.com> | 2019-04-30 13:35:47 +0000 |
---|---|---|
committer | James Lopez <james@gitlab.com> | 2019-04-30 13:35:47 +0000 |
commit | a96e96d5c8829348fed969d00395be93290577d4 (patch) | |
tree | d69a42b8bb9907a1c1fa81f091c759b880637401 | |
parent | 56c8b35b8460dac53e6d29c3c811da4e57eca66c (diff) | |
parent | 60525148e7532934913b56586ccdd4c37b74a637 (diff) | |
download | gitlab-ce-a96e96d5c8829348fed969d00395be93290577d4.tar.gz |
Merge branch 'fix-danger-when-nobody-in-category' into 'master'
Fix reviewer roulette when no-one is in a category
See merge request gitlab-org/gitlab-ce!27895
-rw-r--r-- | danger/roulette/Dangerfile | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/danger/roulette/Dangerfile b/danger/roulette/Dangerfile index 27763052192..62e5526c02b 100644 --- a/danger/roulette/Dangerfile +++ b/danger/roulette/Dangerfile @@ -57,10 +57,12 @@ def spin_for_person(people, random:) people.size.times do person = people.sample(random: random) - return person unless out_of_office?(person) + break person unless out_of_office?(person) people -= [person] end + + person end def out_of_office?(person) |