Code improvements

8 files changed, 14 insertions, 25 deletions

diff --git a/app/assets/javascripts/dispatcher.js b/app/assets/javascripts/dispatcher.js
index 2ff7ff308a7..370aedd634a 100644
--- a/app/assets/javascripts/dispatcher.js
+++ b/app/assets/javascripts/dispatcher.js
@@ -346,6 +346,7 @@ import Activities from './activities';
           import('./pages/projects/show')
             .then(callDefault)
             .catch(fail);
+          shortcut_handler = true;
           break;
         case 'projects:edit':
           import('./pages/projects/edit')
diff --git a/app/assets/javascripts/pages/projects/releases/index.js b/app/assets/javascripts/pages/projects/init_form.js
index 1fa5ffbf586..0b6c5c1d30b 100644
--- a/app/assets/javascripts/pages/projects/releases/index.js
+++ b/app/assets/javascripts/pages/projects/init_form.js
@@ -1,7 +1,7 @@
 import ZenMode from '~/zen_mode';
 import GLForm from '~/gl_form';
 
-export default function () {
+export default function ($formEl) {
   new ZenMode(); // eslint-disable-line no-new
-  new GLForm($('.release-form'), true); // eslint-disable-line no-new
+  new GLForm($formEl, true); // eslint-disable-line no-new
 }
diff --git a/app/assets/javascripts/pages/projects/releases/edit/index.js b/app/assets/javascripts/pages/projects/releases/edit/index.js
new file mode 100644
index 00000000000..3d997cdfff0
--- /dev/null
+++ b/app/assets/javascripts/pages/projects/releases/edit/index.js
@@ -0,0 +1,3 @@
+import initForm from '~/pages/projects/init_form';
+
+export default initForm($('.release-form'));
diff --git a/app/assets/javascripts/pages/projects/settings/repository/show/index.js b/app/assets/javascripts/pages/projects/settings/repository/show/index.js
index d22b2bb8950..83b5467fbc0 100644
--- a/app/assets/javascripts/pages/projects/settings/repository/show/index.js
+++ b/app/assets/javascripts/pages/projects/settings/repository/show/index.js
@@ -1,6 +1,3 @@
 import initSettingsPanels from '~/settings_panels';
 
-export default function () {
-  // Initialize expandable settings panels
-  initSettingsPanels();
-}
+export default initSettingsPanels;
diff --git a/app/assets/javascripts/pages/projects/show/index.js b/app/assets/javascripts/pages/projects/show/index.js
index 5a47284392d..ff387eec104 100644
--- a/app/assets/javascripts/pages/projects/show/index.js
+++ b/app/assets/javascripts/pages/projects/show/index.js
@@ -6,7 +6,7 @@ import BlobViewer from '~/blob/viewer/index';
 import Activities from '~/activities';
 import { ajaxGet } from '~/lib/utils/common_utils';
 
-export default function () {
+export default () => {
   new ShortcutsNavigation(); // eslint-disable-line no-new
   new NotificationsForm(); // eslint-disable-line no-new
   new UserCallout({ // eslint-disable-line no-new
diff --git a/app/assets/javascripts/pages/projects/snippets/create/index.js b/app/assets/javascripts/pages/projects/snippets/create/index.js
index fac4e49c473..9edb16dc73b 100644
--- a/app/assets/javascripts/pages/projects/snippets/create/index.js
+++ b/app/assets/javascripts/pages/projects/snippets/create/index.js
@@ -1,7 +1,3 @@
-import GLForm from '~/gl_form';
-import ZenMode from '~/zen_mode';
+import initForm from '~/pages/projects/init_form';
 
-export default function () {
-  new GLForm($('.snippet-form'), true); // eslint-disable-line no-new
-  new ZenMode(); // eslint-disable-line no-new
-}
+export default initForm($('.snippet-form'));
diff --git a/app/assets/javascripts/pages/projects/snippets/edit/index.js b/app/assets/javascripts/pages/projects/snippets/edit/index.js
index fac4e49c473..9edb16dc73b 100644
--- a/app/assets/javascripts/pages/projects/snippets/edit/index.js
+++ b/app/assets/javascripts/pages/projects/snippets/edit/index.js
@@ -1,7 +1,3 @@
-import GLForm from '~/gl_form';
-import ZenMode from '~/zen_mode';
+import initForm from '~/pages/projects/init_form';
 
-export default function () {
-  new GLForm($('.snippet-form'), true); // eslint-disable-line no-new
-  new ZenMode(); // eslint-disable-line no-new
-}
+export default initForm($('.snippet-form'));
diff --git a/app/assets/javascripts/pages/projects/snippets/update/index.js b/app/assets/javascripts/pages/projects/snippets/update/index.js
index fac4e49c473..7538945d061 100644
--- a/app/assets/javascripts/pages/projects/snippets/update/index.js
+++ b/app/assets/javascripts/pages/projects/snippets/update/index.js
@@ -1,7 +1,3 @@
-import GLForm from '~/gl_form';
-import ZenMode from '~/zen_mode';
+import initSnippets from '~/pages/projects/snippets/init_snippets';
 
-export default function () {
-  new GLForm($('.snippet-form'), true); // eslint-disable-line no-new
-  new ZenMode(); // eslint-disable-line no-new
-}
+export default initSnippets;