summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Speicher <rspeicher@gmail.com>2016-05-08 15:28:21 -0400
committerRobert Speicher <rspeicher@gmail.com>2016-05-16 14:52:03 -0500
commit3950f8074c078fb9320c3e9a468da15feb2d103e (patch)
tree4f631c842b265aa15ed7729ccd683097367692bf
parentc05ed99bff637f51d16cc34663b911e46295a473 (diff)
downloadgitlab-ce-3950f8074c078fb9320c3e9a468da15feb2d103e.tar.gz
Fix titles for commit references in Event feed
Prior, the `title` attribute was being included as an argument to the route helper rather than as an argument to `link_to`.
-rw-r--r--app/helpers/events_helper.rb3
1 files changed, 2 insertions, 1 deletions
diff --git a/app/helpers/events_helper.rb b/app/helpers/events_helper.rb
index 2b33889b46a..73320d8841d 100644
--- a/app/helpers/events_helper.rb
+++ b/app/helpers/events_helper.rb
@@ -150,7 +150,8 @@ module EventsHelper
link_to(
namespace_project_commit_path(event.project.namespace, event.project,
event.note_commit_id,
- anchor: dom_id(event.target), title: h(event.target_title)),
+ anchor: dom_id(event.target)),
+ title: h(event.target_title),
class: "commit_short_id"
) do
"#{event.note_target_type} #{event.note_short_commit_id}"