summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaco Guzman <pacoguzmanp@gmail.com>2016-10-19 21:58:12 +0200
committerPaco Guzman <pacoguzmanp@gmail.com>2016-10-19 21:58:12 +0200
commit325a5bafcc8a37b7d2ed1416b2952862066a914f (patch)
tree30670d0fbe51429d38b7a8ca1b6df622718e3509
parent44f718c9a08ac49f0926c40d2d0d0e31ecf517f8 (diff)
downloadgitlab-ce-325a5bafcc8a37b7d2ed1416b2952862066a914f.tar.gz
Simpler arguments passed to named_route on toggle_award_url helper method6967-toggle_award_url
-rw-r--r--CHANGELOG.md1
-rw-r--r--app/helpers/award_emoji_helper.rb4
2 files changed, 3 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index e185d030ed5..421f0496025 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,7 @@
Please view this file on the master branch, on stable branches it's out of date.
## 8.14.0 (2016-11-22)
+ - Simpler arguments passed to named_route on toggle_award_url helper method
## 8.13.0 (2016-10-22)
diff --git a/app/helpers/award_emoji_helper.rb b/app/helpers/award_emoji_helper.rb
index 592ffe7b89f..167b09e678f 100644
--- a/app/helpers/award_emoji_helper.rb
+++ b/app/helpers/award_emoji_helper.rb
@@ -3,8 +3,8 @@ module AwardEmojiHelper
return url_for([:toggle_award_emoji, awardable]) unless @project
if awardable.is_a?(Note)
- # We render a list of notes very frequently and calling the specific method is a lot faster than the generic one (6.5x)
- toggle_award_emoji_namespace_project_note_url(namespace_id: @project.namespace, project_id: @project, id: awardable.id)
+ # We render a list of notes very frequently and calling the specific method is a lot faster than the generic one (4.5x)
+ toggle_award_emoji_namespace_project_note_url(@project.namespace, @project, awardable.id)
else
url_for([:toggle_award_emoji, @project.namespace.becomes(Namespace), @project, awardable])
end