summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorClement Ho <clemmakesapps@gmail.com>2018-05-31 14:03:46 +0000
committerClement Ho <clemmakesapps@gmail.com>2018-05-31 14:03:46 +0000
commitafac3f02e2ea0b1568cfac6d6671bf00baf7d1dc (patch)
treee9f3767baf9a5389b602259f045eb4cf0db5a427
parentfeab9afd30719c99d6b46203ab7a05ff101055bc (diff)
parent0fbd948b8d43023338264a599ff7b60dbf248fcd (diff)
downloadgitlab-ce-afac3f02e2ea0b1568cfac6d6671bf00baf7d1dc.tar.gz
Merge branch 'winh-capybara-html-hack-docs' into 'master'
Add link to hack for styling Capybara HTML dumps See merge request gitlab-org/gitlab-ce!19205
-rw-r--r--doc/development/testing_guide/best_practices.md4
1 files changed, 4 insertions, 0 deletions
diff --git a/doc/development/testing_guide/best_practices.md b/doc/development/testing_guide/best_practices.md
index a76a5096b69..1a926a660f1 100644
--- a/doc/development/testing_guide/best_practices.md
+++ b/doc/development/testing_guide/best_practices.md
@@ -120,6 +120,10 @@ Add `screenshot_and_save_page` in a `:js` spec to screenshot what Capybara
Add `screenshot_and_open_image` in a `:js` spec to screenshot what Capybara
"sees", and automatically open the image.
+The HTML dumps created by this are missing CSS.
+This results in them looking very different from the actual application.
+There is a [small hack](https://gitlab.com/gitlab-org/gitlab-ce/snippets/1718469) to add CSS which makes debugging easier.
+
### Fast unit tests
Some classes are well-isolated from Rails and you should be able to test them