diff options
author | Fatih Acet <acetfatih@gmail.com> | 2016-09-24 10:07:17 +0000 |
---|---|---|
committer | Fatih Acet <acetfatih@gmail.com> | 2016-09-24 10:07:17 +0000 |
commit | a69afc53695506b8e32f836514f5890353ecea5f (patch) | |
tree | 49b0d57a70ca0778ab79e5026e0583f9b8b29cda | |
parent | 640ab3072ff278c052ab0e2a5eaec69d684db753 (diff) | |
parent | ae341be8851518762d3a28639695576e21efb166 (diff) | |
download | gitlab-ce-a69afc53695506b8e32f836514f5890353ecea5f.tar.gz |
Merge branch '22459-tooltips-for-mini-pipeline-graph-in-pipeline-list-use-the-svg-instead-of-container' into 'master'
Fixed pipeline stage svg link tooltip
## What does this MR do?
Adds `display: block` to the `.stage-container` class which allows the dimensional constraints of the link to be calculated correctly so the `mouseover` events are fired correctly.
## Are there points in the code the reviewer needs to double check?
## Why was this MR needed?
Hovering the stage icons to reveal their SVG was buggy and would flash.
## Screenshots (if relevant)
![2016-09-23_14.59.17](/uploads/ad4c85fb08f032cc3f5d17749d3f7091/2016-09-23_14.59.17.gif)
I just realised that Gifox actually adds its own mouse that isn't positioned or sized correctly so this doesn't look right, you'll have to `checkout` to confirm.
/cc @dimitrieh I found a con about Gifox! :laughing:
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #22459
See merge request !6494
-rw-r--r-- | app/assets/stylesheets/pages/pipelines.scss | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/app/assets/stylesheets/pages/pipelines.scss b/app/assets/stylesheets/pages/pipelines.scss index 1b4d12d3053..b035bfc9f3c 100644 --- a/app/assets/stylesheets/pages/pipelines.scss +++ b/app/assets/stylesheets/pages/pipelines.scss @@ -177,6 +177,10 @@ border-bottom: 2px solid $border-color; } } + + a { + display: block; + } } } |