diff options
| author | Achilleas Pipinellis <axilleas@axilleas.me> | 2015-12-10 21:06:53 +0000 |
|---|---|---|
| committer | Achilleas Pipinellis <axilleas@axilleas.me> | 2015-12-10 21:06:53 +0000 |
| commit | 667065700bc2ef4c687043d9e6ef5eb500df09a3 (patch) | |
| tree | 395a446ae9411cb5b531b6f63110aedec1775d84 | |
| parent | fb07f706b51828b03d6adff81f6d0fc7ad3fb5f2 (diff) | |
| parent | 63a1a581e937ff6d21e7e6ca4774b7907c6a0c1b (diff) | |
| download | gitlab-ce-667065700bc2ef4c687043d9e6ef5eb500df09a3.tar.gz | |
Merge branch 'user_file_uploads_documentation' into 'master'
Document file upload random uuid security
This documents the current state of file uploads regarding random UUID and security.
Fixes #3569
Thanks to @DouweM for the language.
cc/ @sytses @JobV @axil Does this look OK?
See merge request !2055
| -rw-r--r-- | doc/security/README.md | 3 | ||||
| -rw-r--r-- | doc/security/user_file_uploads.md | 11 |
2 files changed, 13 insertions, 1 deletions
diff --git a/doc/security/README.md b/doc/security/README.md index 473f3632dcd..fba6013d9c1 100644 --- a/doc/security/README.md +++ b/doc/security/README.md @@ -4,4 +4,5 @@ - [Rack attack](rack_attack.md) - [Web Hooks and insecure internal web services](webhooks.md) - [Information exclusivity](information_exclusivity.md) -- [Reset your root password](reset_root_password.md)
\ No newline at end of file +- [Reset your root password](reset_root_password.md) +- [User File Uploads](user_file_uploads.md) diff --git a/doc/security/user_file_uploads.md b/doc/security/user_file_uploads.md new file mode 100644 index 00000000000..98493d33b00 --- /dev/null +++ b/doc/security/user_file_uploads.md @@ -0,0 +1,11 @@ +# User File Uploads + +Images attached to issues, merge requests or comments do not require authentication +to be viewed if someone knows the direct URL. This direct URL contains a random +32-character ID that prevents unauthorized people from guessing the URL to an +image containing sensitive information. We don't enable authentication because +these images need to be visible in the body of notification emails, which are +often read from email clients that are not authenticated with GitLab, like +Outlook, Apple Mail, or the Mail app on your mobile device. + +Note that non-image attachments do require authentication to be viewed. |