diff options
| author | Sean McGivern <sean@mcgivern.me.uk> | 2017-07-21 18:50:42 +0000 |
|---|---|---|
| committer | Sean McGivern <sean@mcgivern.me.uk> | 2017-07-21 18:50:42 +0000 |
| commit | f23d74345a3e64ff7560cbff3019a86d399bd3ad (patch) | |
| tree | 32d8640da203dcafbc479777e9a3119b9751ead9 | |
| parent | 2209426f7ba1a0c40b09e5b67ac3b48fd15f7b99 (diff) | |
| parent | 921e5ab0e1c7e8b4023ee103d3ca04f4f9180adb (diff) | |
| download | gitlab-ce-f23d74345a3e64ff7560cbff3019a86d399bd3ad.tar.gz | |
Merge branch 'dz-sidekiq-remove-queue' into 'master'
Update sidekiq style guide with rename/remove queue instructions
Closes #34223
See merge request !13009
| -rw-r--r-- | doc/development/sidekiq_style_guide.md | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/doc/development/sidekiq_style_guide.md b/doc/development/sidekiq_style_guide.md index e3a20f29a09..1e9fdbc65e2 100644 --- a/doc/development/sidekiq_style_guide.md +++ b/doc/development/sidekiq_style_guide.md @@ -36,3 +36,10 @@ slow jobs blocking work (even for different jobs) on the shared queue. Each Sidekiq worker must be tested using RSpec, just like any other class. These tests should be placed in `spec/workers`. + +## Removing or renaming queues + +Try to avoid renaming or removing queues in minor and patch releases. +During online update instance can have pending jobs and removing the queue can +lead to those jobs being stuck forever. If you can't write migration for those +Sidekiq jobs, please consider doing rename or remove queue in major release only.
\ No newline at end of file |