summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2016-11-10 19:32:02 +0000
committerFilipa Lacerda <filipa@gitlab.com>2016-12-21 17:34:41 +0000
commit294d039facf3ff243531b0ccb8f161398716b5a8 (patch)
treef2098c11aad0ef5330463abe02370b6d5707899a
parentc84656bb72258e7c69876ba42d965fa31fffbf4d (diff)
downloadgitlab-ce-294d039facf3ff243531b0ccb8f161398716b5a8.tar.gz
Swap `event` for `e`
-rw-r--r--app/assets/javascripts/header.js.es64
-rw-r--r--app/assets/javascripts/lib/utils/customevent_polyfill.js.es64
-rw-r--r--app/assets/javascripts/right_sidebar.js4
-rw-r--r--app/assets/javascripts/sidebar.js.es64
-rw-r--r--app/assets/javascripts/todos.js.es64
-rw-r--r--spec/javascripts/dashboard_spec.js.es64
-rw-r--r--spec/javascripts/header_spec.js.es64
7 files changed, 14 insertions, 14 deletions
diff --git a/app/assets/javascripts/header.js.es6 b/app/assets/javascripts/header.js.es6
index 0dd0cebf3a3..f8e4cb636b8 100644
--- a/app/assets/javascripts/header.js.es6
+++ b/app/assets/javascripts/header.js.es6
@@ -1,6 +1,6 @@
-document.addEventListener('todo:toggle', (event) => {
+document.addEventListener('todo:toggle', (e) => {
const todoPendingCount = document.querySelector('.todos-pending-count');
- const count = event.detail.count;
+ const count = e.detail.count;
if (todoPendingCount !== null) {
todoPendingCount.textContent = gl.text.addDelimiter(count);
diff --git a/app/assets/javascripts/lib/utils/customevent_polyfill.js.es6 b/app/assets/javascripts/lib/utils/customevent_polyfill.js.es6
index 740f063dd76..5ae978010c9 100644
--- a/app/assets/javascripts/lib/utils/customevent_polyfill.js.es6
+++ b/app/assets/javascripts/lib/utils/customevent_polyfill.js.es6
@@ -2,10 +2,10 @@
* CustomEvent support for IE
*/
if (typeof window.CustomEvent !== 'function') {
- window.CustomEvent = function CustomEvent(event, params) {
+ window.CustomEvent = function CustomEvent(e, params) {
const options = params || { bubbles: false, cancelable: false, detail: undefined };
const evt = document.createEvent('CustomEvent');
- evt.initCustomEvent(event, options.bubbles, options.cancelable, options.detail);
+ evt.initCustomEvent(e, options.bubbles, options.cancelable, options.detail);
return evt;
};
window.CustomEvent.prototype = window.Event.prototype;
diff --git a/app/assets/javascripts/right_sidebar.js b/app/assets/javascripts/right_sidebar.js
index c6fbc508f38..f909ff28d18 100644
--- a/app/assets/javascripts/right_sidebar.js
+++ b/app/assets/javascripts/right_sidebar.js
@@ -84,13 +84,13 @@
};
Sidebar.prototype.todoUpdateDone = function(data, $btn, $btnText, $todoLoading) {
- const event = new CustomEvent('todo:toggle', {
+ const toggleTodoEvent = new CustomEvent('todo:toggle', {
detail: {
count: data.count,
},
});
- document.dispatchEvent(event);
+ document.dispatchEvent(toggleTodoEvent);
$btn.enable();
$todoLoading.addClass('hidden');
diff --git a/app/assets/javascripts/sidebar.js.es6 b/app/assets/javascripts/sidebar.js.es6
index d73d775074c..92547da07ce 100644
--- a/app/assets/javascripts/sidebar.js.es6
+++ b/app/assets/javascripts/sidebar.js.es6
@@ -42,8 +42,8 @@
.on('click', 'html, body', (e) => this.handleClickEvent(e))
.on('page:change', () => this.renderState());
- document.addEventListener('todo:toggle', (event) => {
- this.updateTodoCount(event.detail.count);
+ document.addEventListener('todo:toggle', (e) => {
+ this.updateTodoCount(e.detail.count);
});
this.renderState();
diff --git a/app/assets/javascripts/todos.js.es6 b/app/assets/javascripts/todos.js.es6
index d9c1a739ee4..560d1e6578f 100644
--- a/app/assets/javascripts/todos.js.es6
+++ b/app/assets/javascripts/todos.js.es6
@@ -101,13 +101,13 @@
}
updateBadges(data) {
- const event = new CustomEvent('todo:toggle', {
+ const toggleTodoEvent = new CustomEvent('todo:toggle', {
detail: {
count: data.count,
},
});
- document.dispatchEvent(event);
+ document.dispatchEvent(toggleTodoEvent);
$('.todos-pending .badge').text(data.count);
return $('.todos-done .badge').text(data.done_count);
diff --git a/spec/javascripts/dashboard_spec.js.es6 b/spec/javascripts/dashboard_spec.js.es6
index 3d2a9be401e..302e707ca59 100644
--- a/spec/javascripts/dashboard_spec.js.es6
+++ b/spec/javascripts/dashboard_spec.js.es6
@@ -16,12 +16,12 @@
}
function triggerToggle(newCount) {
- const event = new CustomEvent('todo:toggle', {
+ const toggleTodoEvent = new CustomEvent('todo:toggle', {
detail: {
count: newCount,
},
});
- document.dispatchEvent(event);
+ document.dispatchEvent(toggleTodoEvent);
}
fixture.preload(fixtureTemplate);
diff --git a/spec/javascripts/header_spec.js.es6 b/spec/javascripts/header_spec.js.es6
index 33b0c979b59..61f28a32131 100644
--- a/spec/javascripts/header_spec.js.es6
+++ b/spec/javascripts/header_spec.js.es6
@@ -10,13 +10,13 @@ describe('Header', () => {
};
const triggerToggle = (newCount) => {
- const event = new CustomEvent('todo:toggle', {
+ const toggleTodoEvent = new CustomEvent('todo:toggle', {
detail: {
count: newCount,
},
});
- document.dispatchEvent(event);
+ document.dispatchEvent(toggleTodoEvent);
};
fixture.preload(fixtureTemplate);