diff options
| author | Luke Duncalfe <lduncalfe@eml.cc> | 2019-05-20 17:13:29 +1200 |
|---|---|---|
| committer | Luke Duncalfe <lduncalfe@eml.cc> | 2019-05-22 11:37:46 +1200 |
| commit | 3783c23457adaa4a1f97ffd0891a1a5a8d02f188 (patch) | |
| tree | d04f149ae9397185a0409f5d09dc9ee00c18357b | |
| parent | e6d87e2214c3f49f0acf281f42f3b5ecd42bc85a (diff) | |
| download | gitlab-ce-3783c23457adaa4a1f97ffd0891a1a5a8d02f188.tar.gz | |
Link to issue in CodeReuse/ActiveRecord messagelink-to-issue-in-code-reuse-active-record-rubocop-rule
This provides the user with some context as to why certain ActiveRecord
methods are blacklisted.
| -rw-r--r-- | rubocop/cop/code_reuse/active_record.rb | 3 | ||||
| -rw-r--r-- | spec/rubocop/cop/code_reuse/active_record_spec.rb | 6 |
2 files changed, 5 insertions, 4 deletions
diff --git a/rubocop/cop/code_reuse/active_record.rb b/rubocop/cop/code_reuse/active_record.rb index 2be8f7c11aa..1e650abfceb 100644 --- a/rubocop/cop/code_reuse/active_record.rb +++ b/rubocop/cop/code_reuse/active_record.rb @@ -9,7 +9,8 @@ module RuboCop class ActiveRecord < RuboCop::Cop::Cop include CodeReuseHelpers - MSG = 'This method can only be used inside an ActiveRecord model' + MSG = 'This method can only be used inside an ActiveRecord model: ' \ + 'https://gitlab.com/gitlab-org/gitlab-ce/issues/49653' # Various methods from ActiveRecord::Querying that are blacklisted. We # exclude some generic ones such as `any?` and `first`, as these may diff --git a/spec/rubocop/cop/code_reuse/active_record_spec.rb b/spec/rubocop/cop/code_reuse/active_record_spec.rb index a30fc52d26f..8f3a3690d88 100644 --- a/spec/rubocop/cop/code_reuse/active_record_spec.rb +++ b/spec/rubocop/cop/code_reuse/active_record_spec.rb @@ -14,7 +14,7 @@ describe RuboCop::Cop::CodeReuse::ActiveRecord do expect_offense(<<~SOURCE) def foo User.where - ^^^^^ This method can only be used inside an ActiveRecord model + ^^^^^ This method can only be used inside an ActiveRecord model: https://gitlab.com/gitlab-org/gitlab-ce/issues/49653 end SOURCE end @@ -23,7 +23,7 @@ describe RuboCop::Cop::CodeReuse::ActiveRecord do expect_offense(<<~SOURCE) def foo User.where(id: 10) - ^^^^^ This method can only be used inside an ActiveRecord model + ^^^^^ This method can only be used inside an ActiveRecord model: https://gitlab.com/gitlab-org/gitlab-ce/issues/49653 end SOURCE end @@ -40,7 +40,7 @@ describe RuboCop::Cop::CodeReuse::ActiveRecord do expect_offense(<<~SOURCE) def foo project.group(:name) - ^^^^^ This method can only be used inside an ActiveRecord model + ^^^^^ This method can only be used inside an ActiveRecord model: https://gitlab.com/gitlab-org/gitlab-ce/issues/49653 end SOURCE end |